Skip to content

Add len and count rate methods to flash loader #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zain-sohail
Copy link
Member

No description provided.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13634895049

Details

  • 24 of 39 (61.54%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.174%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sed/loader/flash/loader.py 24 39 61.54%
Totals Coverage Status
Change from base Build 13498273640: -0.1%
Covered Lines: 7820
Relevant Lines: 8484

💛 - Coveralls

@zain-sohail
Copy link
Member Author

zain-sohail commented Mar 28, 2025

  • add sp.info to show the metadata

@zain-sohail zain-sohail requested a review from Copilot April 6, 2025 16:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • .cspell/custom-dictionary.txt: Language not supported

Comment on lines +271 to +272
raise TypeError(f"get_elapsed_time() got unexpected keyword arguments {kwds.keys()}.")

Copy link
Preview

Copilot AI Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message incorrectly references 'get_elapsed_time'; it should reference 'get_count_rate' instead to accurately reflect the context of the error.

Suggested change
raise TypeError(f"get_elapsed_time() got unexpected keyword arguments {kwds.keys()}.")
raise TypeError(f"get_count_rate() got unexpected keyword arguments {kwds.keys()}.")

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants