[WIP] Nominations form updates #226
Open
+936
−738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chimon2000
commented
Oct 27, 2018
•
chimon2000
commented
- Display a message to nominators if they enter a child that is older than fourteen years old. It will still allow the user to submit the form.
- Move "reason for nomination" away from child; put on head of household section instead. Make a required field.
- Change child age calculation to be based on their age on Christmas instead of the current date.
- Add text around the wishlist text area to only enter toys that are under $50
- Change "# in household" to "Number of kids being nominated"
- When submitting the form, check whether the number of children actually entered does not match the number entered in the Number of kids field, alert the user of the discrepancy. We don't want to automatically calculate the number of children nominated; the field serves as a double-checking tool for the nominator.
Also added warning if child too old.
AndrewNatoli
requested changes
Oct 28, 2018
| <div> | ||
| {nominations && | ||
| nominations.map((row, idx) => { | ||
| const dob = pathOr(new Date(), "dob", fields.value[idx]); |
There was a problem hiding this comment.
getting a fields is not defined error
| <Row> | ||
| {isTooOld && ( | ||
| <Col xs={12}> | ||
| <Alert bsStyle="warning" key={name}> |
There was a problem hiding this comment.
name apparently makes the no-restricted-globals linter go mad 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.