185 windows fix dynamic libraries build #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryResults for commit: 3c69e89 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
add export or import declarations, to be able to build libraries as dll
add export or import declarations, to be able to build libraries as dll also make RecordingReader an iterator
with this workaround we don't need to add __declspec() everywhere
add export or import declarations, to be able to build libraries as dll
add export or import declarations, to be able to build libraries as dll
Totto16
force-pushed
the
185-windows-fix-dynamic-libraries-build
branch
from
e57a613 to
928076f
Compare
Totto16
force-pushed
the
185-windows-fix-dynamic-libraries-build
branch
from
928076f to
4c52be1
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
No concerns from clang-tidy.
Click here for the full clang-format patch
diff --git a/src/libs/core/helper/sleep.hpp b/src/libs/core/helper/sleep.hpp
index 4244858..f86c1c3 100644
--- a/src/libs/core/helper/sleep.hpp
+++ b/src/libs/core/helper/sleep.hpp
@@ -10 +9,0 @@ namespace helper {
-
Have any feedback or feature suggestions? Share it here.
also adjust the cpp-linter arguments
Totto16
force-pushed
the
185-windows-fix-dynamic-libraries-build
branch
from
2b2953a to
3c69e89
Compare
Totto16
dismissed
github-actions[bot]’s stale review
since it wasn't cleared after it was solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.