Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tool usage with tablet eraser #1193

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

letsfindaway
Copy link
Collaborator

This PR tries to fix #437.

  • use correct tool after switching to/from tablet eraser
  • re-evaluate currentTool after changing it by the tablet eraser

However I need some testers, as I do not have a tablet with an eraser function. I will add this PR as a patch to my experimental builds, so that experimental packages are available later this day.

@bruening-bw : there will be packages for several versions of Debian available. So it would be helpful if you could test whether this fixes the issue for you.

kaamui and others added 4 commits December 17, 2024 15:05
- use correct tool after switching to/from tablet eraser
- re-evaluate currentTool after changing it by the tablet eraser
@bruening-bw
Copy link

The eraser works as it should. When I use the eraser on the back end of the pen, it works immediately. And if I use the pen again with the tip, it switches back to the drawing tool and is pressure sensitive from the first stroke. This works with the pen and the marker and the straight line tool.

If I have selected the laser pointer and then use the eraser, it does not switch back to the laser pointer afterwards, but to the last drawing tool used before. The same applies to all other tools that are not used for drawing, such as scissors, the selection tool, text, zoom, hand, etc. But that's not a problem. No need to bother with it.

I have also tried the eraser in desktop mode. It works great when erasing on the desktop.

I didn't notice any unwanted side effects during my tests.

@letsfindaway
Copy link
Collaborator Author

If I have selected the laser pointer and then use the eraser, it does not switch back to the laser pointer afterwards, but to the last drawing tool used before. The same applies to all other tools that are not used for drawing, such as scissors, the selection tool, text, zoom, hand, etc. But that's not a problem. No need to bother with it.

This is something which could be changed, too. But I would classify it as a "behavior" and not as a "bug" and would like to have some feedback from @kaamui before changing the behavior.

I didn't notice any unwanted side effects during my tests.

Thanks for testing. And thanks for bringing up this old topic again - I think it was just forgotten.

So I hope it will be fixed in the next release of OpenBoard.

@letsfindaway letsfindaway changed the base branch from master to dev January 8, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pen pressure not recognized after holding erase button on pen
3 participants