Feat: improve shortcut handling #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- group actions instead of buttons in UBActionPalette - associate actions with MainWindow - add option to ignore Ctrl key - set icon on action instead of button - assigning a shortcut in the UBShortcutManager changes actions - changing an action re-assignes the action's icon to the button - a previously set buutton icon is overwritten - setting the icon at the action avoids this
- switch between tools in board mode even if pen down - new tool starts at current position
- add UBActionGroupHistory - listen for key release events to return to previous tool
letsfindaway
force-pushed
the
feat-improve-shortcut-handling
branch
from
a8853ee to
43feb34
Compare
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of #955 with all the improvements in shortcut handling, but without the preferences dialog.
It contains all improvements described here: #955 (comment).
It also contains the option to use shortcuts without the
Ctrlmodifier by settingin the configuration file. This is especially useful to activate shortcuts with a single hand.
Note that this PR already contains the full-fledged
UBShortcutManager, which includes collecting shortcuts from various places and presenting them as a table model for a UI. This is the base for implementing a configuration dialog later, even if many of its functions are currently unused.