Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pen pressure not recognized after holding erase button on pen #437

Open
jonschz opened this issue Jan 27, 2021 · 6 comments · May be fixed by #1193
Open

Pen pressure not recognized after holding erase button on pen #437

jonschz opened this issue Jan 27, 2021 · 6 comments · May be fixed by #1193
Labels
bug

Comments

@jonschz
Copy link

jonschz commented Jan 27, 2021 •
edited
Loading

System: Windows 10, Acer Switch Alpha 12 (with pressure-sensitive pen), version 1.6.1a-1102 [Edit: also on version 1.6.1 release]

On the mentioned version, pressure sensitivity generally works fine (contrary to previous versions, see #302 (comment)). Also, as expected, if I hold Button 2 (I think) on the pen, OpenBoard temporarily changes from pen to eraser.

Steps to reproduce my problem:

  1. Select the "Pen" tool and write something on a fresh board using a (pressure sensitive, physical) pen.
  2. Lift the pen, press and hold button 2 on the pen, then use the pen to erase something.
  3. Lift the pen, then release button 2.
  4. Write something on the board.

Expected behavior:
a) The active tool should change back from "eraser" to "pen" when I release button 2.
b) When I write on the board with the pen in step 4, the pen should write normally and with pressure sensitivity.

Actual behavior:
a) The active tool changes from "eraser" to "pen" the moment I touch the screen with the pen.
b) The first stroke after the change does not recognize pressure sensitivity and draws with constant maximum thickness (as if the pen had no pressure sensitivity). Once I lift the pen off the screen and put it back down, everything goes back to normal.

Please let me know if you need further information.
@kaamui kaamui added the bug label Feb 24, 2021
@kaamui
Copy link
Member

kaamui commented Feb 24, 2021

hello,

thank you for this precise feedback. Really appreciated. It is really specific and you already have a workaround so it won't be a huge priority but I'll try to look at it soon.

What can I say "a priori" is :
a) It might be just that the viewport is not updated at this area until you perform a move with the input device
b) this one is strange. It might prove me wrong for a) and suggest that inputdevicerelease is not called if the input device is lifted off the board before the release is done.

@bruening-bw
Copy link

I can say that this is not "really specific". I use OpenBoard on my HP Eny Convertible with Surface Pen, same problem. I use it on my Wacom Cintiq, same problem. And I also use it on my XP-Pen Artist 16 2nd Gen, same problem. As a result, I can't use the eraser on the back of the pen on any of these devices unless I manually select the eraser tool.

I suspect this problem is quite common. But is not realized by most users simply because their pen does not have an eraser.

There is another bug that is closely related. The first time I touch the screen with the eraser after writing, the eraser circle sticks. I have to touch it twice to use the eraser. This strange behavior stops as soon as the pressure sensitivity is deactivated.

@letsfindaway
Copy link
Collaborator

I think I found the reason why pressure sensitivity is not recognized for the first stroke after switching back from eraser to pen. See the following snippet:

OpenBoard/src/board/UBBoardView.cpp

Lines 348 to 372 in fff1a15

UBStylusTool::Enum currentTool = (UBStylusTool::Enum)dc->stylusTool ();
if (event->type () == QEvent::TabletPress || event->type () == QEvent::TabletEnterProximity) {
#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0))
if (event->pointerType () == QPointingDevice::PointerType::Eraser) {
#else
if (event->pointerType () == QTabletEvent::Eraser) {
#endif
dc->setStylusTool (UBStylusTool::Eraser);
mUsingTabletEraser = true;
}
else {
if (mUsingTabletEraser && currentTool == UBStylusTool::Eraser)
dc->setStylusTool (dc->latestDrawingTool ());
mUsingTabletEraser = false;
}
}
QPointF scenePos = viewportTransform ().inverted ().map (tabletPos);
qreal pressure = 1.0;
if (((currentTool == UBStylusTool::Pen || currentTool == UBStylusTool::Line) && mPenPressureSensitive) ||
(currentTool == UBStylusTool::Marker && mMarkerPressureSensitive))
pressure = event->pressure ();

In line 348, the current tool is determined. Then in some ifs the tool is switched between drawing tool and eraser or back. But in line 370/371 the old value of currentTool is still used.

I don't make a PR for this simple change as I cannot test anything on it.

@bruening-bw
Copy link

I don't know what testing really means. Is it about testing a binary compiled from your fixed code. I could do that on Debian Linux with Wacom Cintiq 22, Wacom Cintiq Pro 16, XP-Pen Artist 16 2nd Gen, XP-Pen Artist Pro 16, ugee U1600, Surface Pen on my HP ENVY and a Wacom AES 1.0 Active Stylus on acer convertibles. These are the devices I have access to. I also could test it on Windows 11. That would be annoying but I would do it if it was helpful. And I have friends working on MacOS. I could arrange for some testing sessions there.

@letsfindaway letsfindaway linked a pull request Dec 29, 2024 that will close this issue
Open
@letsfindaway
Copy link
Collaborator

letsfindaway commented Dec 29, 2024 •
edited
Loading

Thanks to offer testing! I now made this simple PR and created experimental builds including this PR as a patch.

My experimental builds including this patch are now finished. However for Debian-testing and Debian-unstable they are currently failing because of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1088212. This will however automatically be fixed shortly - it already is fixed at Debian and I assume that the openSUSE build environments will be updated until tomorrow.

Note package version of the patched package is 1.7.3 -2. Note the -2 at the end when downloading a package.

To download the packages, go to

Click on your distribution version and download the package from there.

Testing just means to verify that the behavior when using the eraser of the tablet pen is now as you expect.

@bruening-bw
Copy link

I have installed the QT6 version with apt on Debian Stable. This ran without any problems.

The eraser works as it should. When I use the eraser on the back end of the pen, it works immediately. And if I use the pen again with the tip, it switches back to the drawing tool. This works with the pen and the marker and the straight line tool.

If I have selected the laser pointer and then use the eraser, it does not switch back to the laser pointer afterwards, but to the last drawing tool used before. The same applies to all other tools that are not used for drawing, such as scissors, the selection tool, text, zoom, hand, etc. But that's not a problem. No need to bother with it.

I have also tried the eraser in desktop mode. It works great when erasing on the desktop. I noticed that the eraser reacts faster in desktop mode than in whiteboard mode. In fact, it has an input lag on the whiteboard but not on the desktop. I don't see this as a problem and this has nothing to do with your patch. I'm only mentioning it for the sake of interest because some users reported input lags with the pen.

I didn't notice any unwanted side effects during my tests. I have decided to keep the package installed and test it in productive use. I work with the program every day at school. If there is something that is causing problems, I think I would bump into it. Today I used my Wacom Cintiq 22. I think it would make no difference on other devices. But if something strange occurs on XP-Pen devices I will report it in January.

Thanks for the work you are doing. I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: tool usage with tablet eraser letsfindaway/OpenBoard
4 participants
@kaamui @jonschz @letsfindaway @bruening-bw