Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for force_lever output issues #161

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix for force_lever output issues #161

merged 1 commit into from
Feb 19, 2024

Conversation

chryswoods
Copy link
Contributor

This fixes some bugs that were introduced with feature_force_lever that related to how the lever was printed to the screen. Despite the lever working as expected (hence why tests passed), the lever printed to the screen showing that it had no set levers.

Also, in debugging this, I found an issue in the new functionality where a default lever for a force was not being picked up (i.e. ghost/ghost::* was not taking precedence over, e.g. *::charge)

I've updated the unit tests to catch these edge cases

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): [N/A]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers:

@lohedges

Any additional context of information?

This is a minor change to LambdaSchedule. I've not updated the changelog as it this is fixing something introduced in the last PR, which is described in the changelog.

…ixed a bug

in the new functionality where a default lever for a force was not being picked
up (i.e. `ghost/ghost::*` was not taking precedence over, e.g. `*::charge`)

I've updated the unit tests to catch these edge cases
@lohedges
Copy link
Contributor

Thanks for catching this. Looks good 👍

@chryswoods chryswoods merged commit 179aca2 into devel Feb 19, 2024
5 checks passed
@chryswoods chryswoods deleted the fix_schedule branch February 19, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants