Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify python<3.12 in requirements files #148

Closed
wants to merge 2 commits into from

Conversation

fjclark
Copy link
Collaborator

@fjclark fjclark commented Jan 21, 2024

This pull request fixes issue #147 by specifying python<3.12 in the requirements files. I've checked that I can now compile following the instructions in the README.

Sorry, I forgot to specify "ci skip" in my last commit.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): y
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): y
  • I confirm that I have permission to release this code under the GPL3 license: y

Suggested reviewers:

@chryswoods, @lohedges

@chryswoods
Copy link
Contributor

Hi Finlay - we deliberately don't add the Python version as this gets in the way of us testing newer Python versions, and the compile instructions state the supported versions.

Sire itself can compile and work well with 3.12. The challenge comes from missing dependencies. It is their requirements, rather than sire's Python requirement that stops a 3.12 installation from working. As such, we don't version Python, but instead version the other dependencies (which all are > dependencies, rather than <, so that each CI/CD run will use the latest possible version, so that any incompatibility issues will be detected quickly by use during development)

@fjclark
Copy link
Collaborator Author

fjclark commented Jan 22, 2024

Hi Christopher, thanks for the explanation.

@fjclark fjclark closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants