Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Focus Widget values to Session Settings - Fixes #1198 #1199

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

retiutut
Copy link
Member

No description provided.

@retiutut retiutut requested a review from philippitts October 12, 2023 23:38
@retiutut
Copy link
Member Author

CI/CD not configured properly for AWS credentials. Will fix. Good thing to find out in this tiny PR.

Copy link
Member

@philippitts philippitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to save settings a couple issues occur:

  1. The popup window for selecting the file location opens minimized. The GUI window also minimizes.
  2. The default settings name is "SynthEightUserSettings" which doesn't make sense to me. What does this name mean?
  3. When I save using the default "SynthEightUserSettings" name the program crashes.

If I load the settings first, and then try and save new settings it appears to work and none of the above issues occur. However, when I clear the settings and try to reload the newly saved settings, they do not load.

I noticed that three issues I listed at the top of this comment only occur if the Settings folder has not been created. I think the folder is created when loading settings which then allows subsequent saves to work.

The focus widget settings do not load for me regardless if the Settings folder has been created.

Running on Windows 10 from VSCode.

@philippitts
Copy link
Member

philippitts commented Oct 13, 2023

Updates:

  • I'm having trouble reproducing the crash when saving the settings file. I'm not running as administrator so it could be related to that. When the AWS credentials are fixed I'll try running the built artifact as administrator to see if I can replicate the problem.
  • Focus settings are loading. See my UX notes below.

Remaining issues:

  • I just realized that "Synth" is "Synthetic" as applied to the user settings file name. I recommend spelling out the full word instead of using the abbreviation. Maybe I'm special, but it had me confused.
  • When I click "Clear All" it deletes my files. Perhaps that is intended, but as a naive user of this feature I was surprised that it deleted my saved files and kept loading the default "SynthEightDefaultSettings" thinking it was my user saved settings (and then wondering why my settings didn't load). Perhaps renaming this button "Delete Saved Settings" or something similar might make it more clear. The best solution might just be to remove the button since the user can delete settings files using the file browser.
  • Sometimes when I load or save settings files the file selection window appears minimized. This may be because I'm not running as administrator and I'll re-test as described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants