Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix on NPE in case of data being null #1859

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Nov 14, 2024

Proposed changes

  • Fix on NPE in case data we got back from tanium are empty

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.42%. Comparing base (6e03516) to head (1487012).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1859   +/-   ##
=========================================
  Coverage     32.42%   32.42%           
  Complexity     1623     1623           
=========================================
  Files           561      561           
  Lines         16834    16834           
  Branches        984      984           
=========================================
  Hits           5459     5459           
  Misses        11133    11133           
  Partials        242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant