Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Display more payload informations (#1518) #1787

Merged
merged 18 commits into from
Nov 14, 2024
Merged

[frontend] Display more payload informations (#1518) #1787

merged 18 commits into from
Nov 14, 2024

Conversation

johanah29
Copy link
Member

@johanah29 johanah29 self-assigned this Oct 30, 2024
@johanah29
Copy link
Member Author

image

@johanah29 johanah29 marked this pull request as ready for review October 30, 2024 17:06
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.37%. Comparing base (5609c26) to head (649d94a).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1787   +/-   ##
=========================================
  Coverage     32.37%   32.37%           
  Complexity     1623     1623           
=========================================
  Files           561      561           
  Lines         16861    16861           
  Branches        984      984           
=========================================
  Hits           5459     5459           
  Misses        11160    11160           
  Partials        242      242

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumejparis
Copy link
Member

Wait for answer here : #1518

@johanah29 johanah29 marked this pull request as draft October 31, 2024 10:10
@johanah29
Copy link
Member Author

image

@johanah29 johanah29 marked this pull request as ready for review November 4, 2024 10:26
@guillaumejparis guillaumejparis added the filigran team use to identify PR from the Filigran team label Nov 4, 2024
@johanah29
Copy link
Member Author

image

@guillaumejparis guillaumejparis changed the title [frontend]Display more payload informations [frontend] Display more payload informations (#1518) Nov 6, 2024
@johanah29
Copy link
Member Author

image

@johanah29 johanah29 force-pushed the issue/1518 branch 2 times, most recently from 0340c04 to 567a059 Compare November 12, 2024 16:27
@guillaumejparis
Copy link
Member

guillaumejparis commented Nov 13, 2024 •
edited
Loading

Would it be best to make "command" plural?

Like "Attack commands" ...

@johanah29 johanah29 merged commit c6f9eda into master Nov 14, 2024
7 checks passed
@johanah29 johanah29 deleted the issue/1518 branch November 14, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumejparis guillaumejparis guillaumejparis approved these changes

Assignees

@johanah29 johanah29

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanah29 @guillaumejparis