Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Improve latency on exercise overview #1767

Merged
merged 90 commits into from
Nov 15, 2024
Merged

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Oct 29, 2024

Proposed changes

This PR affects the following features:

  • InjectResultDTO has been split into InjectResultOutput and InjectResultOverviewOutput
  • Atomic testing
    List atomic testings (CRUD, filters)
    Atomic testing overview and detail (CRUD, execution)
  • Exercise
    List (CRUD, filters)
    Exercise overview: search injects (CRUD, filters, execution)
  • Scenario
    Scenario overview: exercises, search exercises
  • Reports
    inject results
  • ImportTestSummary
    injects
  • openctiApi
    scenarioService.latestExerciseByExternalReference

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 marked this pull request as ready for review October 30, 2024 09:45
@savacano28 savacano28 self-assigned this Oct 30, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Oct 30, 2024
@savacano28 savacano28 marked this pull request as draft October 30, 2024 09:47
@savacano28 savacano28 force-pushed the bugfix/1729 branch 4 times, most recently from 0e3bc89 to cbeb0e9 Compare November 6, 2024 13:29
@savacano28 savacano28 force-pushed the bugfix/1729 branch 2 times, most recently from f0717a0 to fddd572 Compare November 12, 2024 08:37
@savacano28 savacano28 marked this pull request as ready for review November 12, 2024 08:39
@savacano28 savacano28 marked this pull request as draft November 12, 2024 09:18
@savacano28 savacano28 marked this pull request as ready for review November 12, 2024 09:42
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 59.55734% with 603 lines in your changes missing coverage. Please review.

Project coverage is 33.04%. Comparing base (6e03516) to head (f47aa83).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/io/openbas/service/InjectSearchService.java 28.25% 191 Missing and 2 partials ⚠️
...n/java/io/openbas/service/InjectImportService.java 78.09% 84 Missing and 75 partials ⚠️
...src/main/java/io/openbas/utils/ExerciseMapper.java 0.00% 58 Missing ⚠️
...main/java/io/openbas/utils/AtomicTestingUtils.java 40.42% 28 Missing ⚠️
...pi/src/main/java/io/openbas/utils/InjectUtils.java 34.14% 23 Missing and 4 partials ⚠️
...i/src/main/java/io/openbas/utils/InjectMapper.java 76.28% 23 Missing ⚠️
...nbas/rest/scenario/response/ImportTestSummary.java 12.00% 22 Missing ⚠️
...s/rest/atomic_testing/form/InjectResultOutput.java 0.00% 15 Missing ⚠️
...openbas/rest/exercise/service/ExerciseService.java 88.00% 9 Missing and 3 partials ⚠️
...rc/main/java/io/openbas/service/InjectService.java 14.28% 11 Missing and 1 partial ⚠️
... and 18 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1767      +/-   ##
============================================
+ Coverage     32.42%   33.04%   +0.61%     
- Complexity     1623     1653      +30     
============================================
  Files           561      571      +10     
  Lines         16834    16766      -68     
  Branches        984      972      -12     
============================================
+ Hits           5459     5540      +81     
+ Misses        11133    10979     -154     
- Partials        242      247       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion
Copy link
Member

LGTM :)

@savacano28 savacano28 merged commit 7b2fa64 into master Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve latency on simulation overview Improve latency on simulations list
2 participants