Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1478 fix filter order #1623

Merged
merged 17 commits into from
Oct 11, 2024
Merged

Bugfix/1478 fix filter order #1623

merged 17 commits into from
Oct 11, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Oct 7, 2024

Proposed changes

  • Add default values for status, source on paylaod relation
  • Fix filter for enumerated types : Add operator: empty, no_empty to enumerate types

370716527-fa32c3ca-1b68-4af0-a825-8c346a335746

372936183-18e8807b-9e1b-4273-8109-fad38265acec

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.45%. Comparing base (ab25dcf) to head (73c4b25).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../openbas/rest/payload/form/PayloadCreateInput.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1623      +/-   ##
============================================
+ Coverage     32.41%   32.45%   +0.03%     
- Complexity     1506     1508       +2     
============================================
  Files           544      545       +1     
  Lines         14071    14079       +8     
  Branches        843      843              
============================================
+ Hits           4561     4569       +8     
  Misses         9296     9296              
  Partials        214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review October 7, 2024 07:46
@savacano28 savacano28 self-assigned this Oct 7, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Oct 7, 2024
@damgouj damgouj self-requested a review October 11, 2024 08:14
@savacano28 savacano28 merged commit 9dfb5ce into master Oct 11, 2024
10 checks passed
@savacano28 savacano28 modified the milestone: Release 1.8.0 Oct 11, 2024
@savacano28 savacano28 deleted the bugfix/1478-fix-filter-order branch October 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken filter in payloads list
2 participants