Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix filter priority order #1534

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Sep 25, 2024

Proposed changes

  • Fix filter priority order for enumerated types
    Screenshot 2024-09-25 143940

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Sep 25, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Sep 25, 2024
@savacano28 savacano28 marked this pull request as ready for review September 25, 2024 12:45
@savacano28 savacano28 linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 32.75%. Comparing base (79deada) to head (a3d5652).

Files with missing lines Patch % Lines
.../java/io/openbas/service/AtomicTestingService.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1534      +/-   ##
============================================
- Coverage     32.76%   32.75%   -0.02%     
  Complexity     1502     1502              
============================================
  Files           539      539              
  Lines         13883    13889       +6     
  Branches        824      824              
============================================
  Hits           4549     4549              
- Misses         9124     9130       +6     
  Partials        210      210              
Flag Coverage Δ
32.75% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as draft September 26, 2024 06:36
@savacano28 savacano28 marked this pull request as ready for review September 27, 2024 14:40
Copy link
Member

@damgouj damgouj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) !

@savacano28 savacano28 requested review from RomuDeuxfois and removed request for RomuDeuxfois September 27, 2024 15:10
@savacano28 savacano28 marked this pull request as draft September 27, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken filter in payloads list
3 participants