Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend|frontend]Add the ability to customize the expiration time #1528

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[backend|frontend]Add the ability to customize the expiration time #1528

wants to merge 12 commits into from

Conversation

johanah29
Copy link
Member

@johanah29 johanah29 self-assigned this Sep 25, 2024
@savacano28 savacano28 self-requested a review September 25, 2024 08:04
@johanah29 johanah29 force-pushed the issue/1171 branch 2 times, most recently from cf3983e to c93fcdf Compare September 26, 2024 08:31
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.43537% with 509 lines in your changes missing coverage. Please review.

Project coverage is 32.58%. Comparing base (79deada) to head (52a7dca).

Files with missing lines Patch % Lines
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.45% 218 Missing ⚠️
...nbas/injectors/openbas/OpenBASImplantExecutor.java 0.00% 121 Missing ⚠️
.../io/openbas/injectors/caldera/CalderaContract.java 1.69% 58 Missing ⚠️
...openbas/injectors/challenge/ChallengeExecutor.java 7.14% 52 Missing ⚠️
.../service/ExpectationsExpirationManagerService.java 5.88% 31 Missing and 1 partial ⚠️
...va/io/openbas/service/PlatformSettingsService.java 0.00% 6 Missing ⚠️
.../io/openbas/injectors/opencti/OpenCTIExecutor.java 0.00% 5 Missing ⚠️
.../java/io/openbas/injectors/ovh/OvhSmsExecutor.java 0.00% 5 Missing ⚠️
...enbas/rest/settings/response/PlatformSettings.java 0.00% 5 Missing ⚠️
...java/io/openbas/injectors/email/EmailExecutor.java 55.55% 2 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1528      +/-   ##
============================================
- Coverage     32.76%   32.58%   -0.18%     
- Complexity     1502     1504       +2     
============================================
  Files           539      540       +1     
  Lines         13883    13980      +97     
  Branches        824      836      +12     
============================================
+ Hits           4549     4556       +7     
- Misses         9124     9214      +90     
  Partials        210      210
Flag Coverage Δ
32.58% <13.43%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanah29 johanah29 marked this pull request as ready for review September 26, 2024 10:25
@johanah29 johanah29 linked an issue Sep 26, 2024 that may be closed by this pull request
For expectations, add the ability to customize the expiration time used by the expiration manager #1171
Open
RomuDeuxfois
RomuDeuxfois reviewed Sep 26, 2024
View reviewed changes
openbas-front/src/admin/components/common/injects/expectations/InjectAddExpectation.tsx Outdated Show resolved Hide resolved
openbas-front/src/admin/components/common/injects/expectations/ExpectationPopover.tsx Outdated Show resolved Hide resolved
openbas-front/src/admin/components/common/injects/expectations/ExpectationPopover.tsx Outdated Show resolved Hide resolved
openbas-framework/src/main/java/io/openbas/integrations/PayloadService.java Outdated Show resolved Hide resolved
openbas-api/src/test/java/io/openbas/utils/fixtures/InjectExpectationFixture.java Outdated Show resolved Hide resolved
...s-api/src/main/java/io/openbas/migration/V3_41__Add_column_expiration_time_expectations.java Outdated
Comment on lines 18 to 19
long technicalMinutesExpirationTime = 60L;
long manualMinutesExpirationTime = 360L;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in minute or second ?
To compare with what we have as default in Contract

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in minutes, as mentionned in the name.

openbas-api/src/main/java/io/openbas/injectors/caldera/CalderaContract.java Outdated Show resolved Hide resolved
@RomuDeuxfois
Copy link
Member

When I publish a challenge and the expiration time is reached, I still have the message: Waiting for validation

image

@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Sep 26, 2024 •
edited
Loading

Seems to no working wih channel pressure
image

@johanah29 johanah29 force-pushed the issue/1171 branch 2 times, most recently from 53c61d3 to fcea871 Compare September 27, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savacano28 savacano28 savacano28 left review comments

@RomuDeuxfois RomuDeuxfois RomuDeuxfois requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@johanah29 johanah29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For expectations, add the ability to customize the expiration time used by the expiration manager
3 participants
@johanah29 @RomuDeuxfois @savacano28