Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] add exercise report #1419

Merged
merged 11 commits into from
Sep 20, 2024
Merged

[backend/frontend] add exercise report #1419

merged 11 commits into from
Sep 20, 2024

Conversation

MarineLeM
Copy link
Contributor

issue : #1080

Chunk 1

@MarineLeM MarineLeM added the filigran team use to identify PR from the Filigran team label Sep 12, 2024
@MarineLeM MarineLeM self-assigned this Sep 12, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.55%. Comparing base (29ec77a) to head (7fa3ea2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/main/java/io/openbas/service/ReportService.java 80.95% 4 Missing ⚠️
...rc/main/java/io/openbas/rest/report/ReportApi.java 72.72% 1 Missing and 2 partials ⚠️
...enbas/rest/report/form/ReportInformationInput.java 66.66% 1 Missing ⚠️
.../java/io/openbas/rest/report/form/ReportInput.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1419      +/-   ##
============================================
+ Coverage     32.24%   32.55%   +0.31%     
- Complexity     1451     1464      +13     
============================================
  Files           532      534       +2     
  Lines         13798    13766      -32     
  Branches        821      824       +3     
============================================
+ Hits           4449     4482      +33     
+ Misses         9143     9075      -68     
- Partials        206      209       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarineLeM MarineLeM marked this pull request as ready for review September 13, 2024 08:46
@MarineLeM MarineLeM linked an issue Sep 13, 2024 that may be closed by this pull request
Create customizable debrief page - generate a report page with a global note #1080
Open
RomuDeuxfois
RomuDeuxfois reviewed Sep 17, 2024
View reviewed changes
openbas-api/src/test/java/io/openbas/service/ReportServiceTest.java Show resolved Hide resolved
openbas-model/src/main/java/io/openbas/database/model/Report.java Show resolved Hide resolved
openbas-model/src/main/java/io/openbas/database/model/Report.java
Comment on lines +66 to +69
public int hashCode() {
return Objects.hash(id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can let the @DaTa annotation handle this part

openbas-front/src/utils/api-types.d.ts Outdated Show resolved Hide resolved
openbas-front/src/utils/api-types.d.ts Show resolved Hide resolved
RomuDeuxfois
RomuDeuxfois reviewed Sep 17, 2024
View reviewed changes
openbas-front/src/admin/components/simulations/simulation/ExercisePopover.tsx
@@ -199,6 +206,14 @@ const ExercisePopover: FunctionComponent<ExercisePopoverProps> = ({
)}
</>
</Drawer>
<Drawer
open={openReports}
containerStyle={{ padding: '0px' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you need this ?

Copy link
Contributor Author

@MarineLeM MarineLeM Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to erase the initial padding given into the drawer component

openbas/openbas-front/src/components/common/Drawer.tsx

Line 101 in ae8708d

<div style={containerStyle ?? { padding: '10px 20px 20px 20px' }}>{component}</div>

openbas-front/src/admin/components/common/Context.ts Show resolved Hide resolved
@RomuDeuxfois
Copy link
Member

The text: "this simulation is not running yet. Start now !" should not be there
image

@RomuDeuxfois
Copy link
Member

Can be better to use a group here. We see some spacing between the PDF and the popover button
image

@RomuDeuxfois
Copy link
Member

When i export to image, the export is good but I have this on the navigator
image

@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Sep 17, 2024 •
edited
Loading

When I export to PDF, the PDF has no spacing, it should be in A4 format and look likes a report -> should be check with @jborozco
image

@RomuDeuxfois
Copy link
Member

@MarineLeM ok for me
We need to feature flag this feature for the 1.7 milestone

@MarineLeM MarineLeM merged commit 457dc03 into master Sep 20, 2024
7 checks passed
@MarineLeM MarineLeM deleted the issue/1080 branch September 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomuDeuxfois RomuDeuxfois RomuDeuxfois left review comments

@johanah29 johanah29 johanah29 approved these changes

Assignees

@MarineLeM MarineLeM

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create customizable debrief page - generate a report page with a global note
3 participants
@MarineLeM @RomuDeuxfois @johanah29