Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Add payload elevation required #1410

Merged
merged 11 commits into from
Sep 17, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Sep 11, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.40%. Comparing base (5d61515) to head (7c0f825).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../openbas/rest/payload/form/PayloadUpsertInput.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1410      +/-   ##
============================================
+ Coverage     31.38%   31.40%   +0.01%     
- Complexity     1404     1406       +2     
============================================
  Files           528      529       +1     
  Lines         13707    13712       +5     
  Branches        814      814              
============================================
+ Hits           4302     4306       +4     
- Misses         9205     9206       +1     
  Partials        200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 changed the title Issue/add payload elevation required [backend] add payload elevation required Sep 11, 2024
@savacano28 savacano28 force-pushed the issue/add-payload-elevation-required branch from 59871ed to ad3a556 Compare September 11, 2024 14:28
@savacano28 savacano28 marked this pull request as ready for review September 11, 2024 14:31
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Sep 11, 2024
@savacano28 savacano28 changed the title [backend] add payload elevation required [backend] Add payload elevation required Sep 11, 2024
@RomuDeuxfois RomuDeuxfois force-pushed the issue/add-payload-elevation-required branch from e8d37f0 to 7c0f825 Compare September 17, 2024 09:45
@RomuDeuxfois RomuDeuxfois merged commit 6652873 into master Sep 17, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/add-payload-elevation-required branch September 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants