no longer required to send host_ip

lib/fleet_manager/actions/restart_unit.ex

@@ -8,6 +8,8 @@ defmodule OpenAperture.FleetManager.FleetAction.RestartUnit do
 
   alias OpenAperture.FleetManager.Request, as: FleetRequest
 
+  alias OpenAperture.Fleet.EtcdCluster
+
   @doc """
   Method to execute the following FleetManager action:  :restart_unit
 
@@ -22,9 +24,26 @@ defmodule OpenAperture.FleetManager.FleetAction.RestartUnit do
   @spec execute(FleetRequest.t) :: {:ok, Map} | {:error, String.t}
   def execute(fleet_request) do
     cond do
-      fleet_request.action_parameters[:host_ip] == nil -> {:error, "An invalid 'host_ip' parameter was provided!"}
       fleet_request.action_parameters[:unit_name] == nil -> {:error, "An invalid 'unit_name' parameter was provided!"}
-      true -> execute_script(fleet_request.action_parameters[:host_ip], fleet_request.action_parameters[:unit_name])
+      true -> 
+        hosts = EtcdCluster.get_hosts(fleet_request.etcd_token)
+        if hosts == nil || length(hosts) == 0 do
+          {:error, "Unable to find a valid host - No hosts are available in cluster #{fleet_request.etcd_token}!"}
+        else
+          cur_hosts_cnt = length(hosts)
+          if cur_hosts_cnt == 1 do
+            host = List.first(hosts)
+          else
+            :random.seed(:os.timestamp)
+            host = List.first(Enum.shuffle(hosts))
+          end
+
+          if (host != nil && host.primaryIP != nil) do
+            execute_script(host.primaryIP, fleet_request.action_parameters[:unit_name])
+          else
+            {:error, "Host does not have a valid primaryIP:  #{inspect host}"}
+          end
+        end
     end
   end
 

test/fleet_manager/actions/restart_unit_test.exs

@@ -4,26 +4,40 @@ defmodule OpenAperture.FleetManager.FleetAction.RestartUnitTest do
   alias OpenAperture.FleetManager.Request, as: FleetRequest
   alias OpenAperture.FleetManager.FleetAction.RestartUnit
 
+  alias OpenAperture.Fleet.EtcdCluster
+
   # ===================================
   # execute tests
 
-  test "execute - invalid host_ip" do
-    {status, response} = RestartUnit.execute(%FleetRequest{})
+  test "execute - no unit_name" do
+    {status, response} = RestartUnit.execute(%FleetRequest{
+      action_parameters: %{
+        host_ip: "123.234.456.789"
+      }
+    })
     assert status == :error
     assert response != nil
   end   
 
-  test "execute - no unit_name" do
+  test "execute - no hosts available" do
+    :meck.new(EtcdCluster, [:passthrough])
+    :meck.expect(EtcdCluster, :get_hosts, fn _ -> [] end)
+
     {status, response} = RestartUnit.execute(%FleetRequest{
       action_parameters: %{
-        host_ip: "123.234.456.789"
+        unit_name: "[email protected]"
       }
     })
     assert status == :error
     assert response != nil
-  end   
+  after
+    :meck.unload(EtcdCluster)
+  end  
+
+  test "execute - success" do
+    :meck.new(EtcdCluster, [:passthrough])
+    :meck.expect(EtcdCluster, :get_hosts, fn _ -> [%FleetApi.Machine{primaryIP: "123.234.456.789"}, %FleetApi.Machine{primaryIP: "234.456.789.123"}] end)
 
-  test "execute - nodes" do
     template = File.read!("#{System.cwd!()}/templates/node-info.sh.eex")
 
     :meck.new(File, [:unstick])
@@ -51,11 +65,15 @@ defmodule OpenAperture.FleetManager.FleetAction.RestartUnitTest do
     assert status == :ok
     assert response != nil
   after
+    :meck.unload(EtcdCluster)
     :meck.unload(File)
     :meck.unload(System)
   end  
 
-  test "execute - node info fails" do
+  test "execute - fails" do
+    :meck.new(EtcdCluster, [:passthrough])
+    :meck.expect(EtcdCluster, :get_hosts, fn _ -> [%FleetApi.Machine{primaryIP: "123.234.456.789"}, %FleetApi.Machine{primaryIP: "234.456.789.123"}] end)
+
     template = File.read!("#{System.cwd!()}/templates/node-info.sh.eex")
 
     :meck.new(File, [:unstick])
@@ -83,6 +101,7 @@ defmodule OpenAperture.FleetManager.FleetAction.RestartUnitTest do
     assert status == :error
     assert response != nil
   after
+    :meck.unload(EtcdCluster)
     :meck.unload(File)
     :meck.unload(System)
   end