-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go][Client] Secret key content string in http signing support #8570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream fixes
update with upstream master
jirikuncar
reviewed
Jan 29, 2021
modules/openapi-generator/src/main/resources/go/signing.mustache
Outdated
Show resolved
Hide resolved
jirikuncar
reviewed
Jan 29, 2021
modules/openapi-generator/src/main/resources/go/signing.mustache
Outdated
Show resolved
Hide resolved
jirikuncar
reviewed
Jan 29, 2021
Co-authored-by: Jiri Kuncar <[email protected]>
Co-authored-by: Jiri Kuncar <[email protected]>
modules/openapi-generator/src/main/resources/go/signing.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/go/signing.mustache
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastien Rosset <[email protected]>
Co-authored-by: Sebastien Rosset <[email protected]>
Is this good to merge? If so, please merge. |
Looks like the Go tests (TestInvalidHttpSignatureConfiguration) didn't pass:
|
Failure in the go testcase is fixed. |
Travis CI failure already fixed in the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8569
Accept privateKey content string along with the current option of privateKey file path
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01)