Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-nextgen] Use conditional access for enumref query params #20418

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

JulianVennen
Copy link
Contributor

Query parameters in the php-nextgen generator are passed to the ObjectSerializer::toQueryValue method. For enum refs (which use native PHP enums) the value property, which contains the backing string or number, is passed instead. This causes a PHP warning when the parameter is null. To prevent that, I added a ? which causes the resulting value to be null if the parameter itself is null.

This is not required for header or path parameters, as these are already inside a null check.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@JulianVennen
Copy link
Contributor Author

The typescript test failed due to a network error, I don't think that has anything to do with this PR ;)

@wing328
Copy link
Member

wing328 commented Jan 9, 2025

@wing328 wing328 merged commit 3d2ff49 into OpenAPITools:master Jan 9, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants