-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C][Client] Remove broken intToStr() macro, update samples #20383
Conversation
efd2ba6
to
6608bcd
Compare
Rebased onto current master, made sure to also update the samples just in case something changed. |
Hey @imaami , I sent you a review comment around a week ago. I think you can't see it for some reason? I'm always confused with github. Anyway, this was the comment:
|
Oh damn! I somehow missed it. Let me look at that now... |
@eafer I still don't know where that comment might be, but good catch! Completely a screw-up on my part, the |
Note: this does not fix anything else; for example all numerical types, including float and double, are still incorrectly cast to to long int before string conversion.
6608bcd
to
044141e
Compare
@eafer OK, fixed, rebased onto current master, and regenerated the samples (with no change in the result). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
Note: this does not fix anything else; for example all numerical types, including float and double, are still incorrectly cast to to long int before string conversion.