Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth token refresh to csharp #20234

Merged

Conversation

BryanAldrich
Copy link
Contributor

This adds a simple change to the AuthToken and TokenResponse code to allow for automatic refreshes. (I didn't test the refresh_token since I don't have one of those super handy).

Split off from #20233.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Dec 4, 2024

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

…nd created fields. Also supports refresh_token if that is passed.
@BryanAldrich BryanAldrich force-pushed the AddRefreshToCsharpTemplate branch from 0e4c5b3 to c37a5e7 Compare December 4, 2024 03:05
@BryanAldrich
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Thanks, since I had to fix all that, I hit my mistake.. shh. nobody will know. (i'll fix the other PR I made as well..)

@wing328
Copy link
Member

wing328 commented Dec 4, 2024

can you please review the build failure when you've time?

https://github.com/OpenAPITools/openapi-generator/actions/runs/12152223145/job/33889068846?pr=20234

@BryanAldrich
Copy link
Contributor Author

Sorry i've had all these build failures, this is my first time working with this project, first time working with java since 2004 (yes, 20 years). I've scripted up checks on my side to prevent this again.

@wing328
Copy link
Member

wing328 commented Dec 7, 2024

@BryanAldrich no problem. thanks for the PR.

the appveyor tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/51126886

@wing328 wing328 merged commit f62aa5b into OpenAPITools:master Dec 7, 2024
20 checks passed
@wing328
Copy link
Member

wing328 commented Dec 7, 2024

PR merged. Let's give it a try.

Have a nice weekend

@wing328 wing328 added this to the 7.11.0 milestone Dec 7, 2024
@BryanAldrich BryanAldrich deleted the AddRefreshToCsharpTemplate branch December 9, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants