-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript-axios] [Java] Respect User Supplied Header Params #20032
Conversation
Do I need to run a command to allow this failing workflow to accept the changed test file? Or should I implement the test another way? |
Intent lgtm, unsure about implications, so let's wait for @macjohnny to weigh in. |
this needs to be changed here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
@@ -0,0 +1,59 @@ | |||
<project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has to be registered similar to
openapi-generator/CI/circle_parallel.sh
Line 101 in 57cfff1
(cd samples/client/petstore/typescript-axios/builds/with-npm-version && mvn integration-test) |
@ckoegel please split this PR into two, one for the java generator and one for the typescript generator, so it is easier to revert in case things go wrong |
@macjohnny |
This PR moves the assignment of user supplied header parameters after the automatic OAS defined assignment. This allows the user to define a header parameter and have it be respected instead of overwritten. Changes were made to both the Java
okhttp-gson
andtypescript-axios
generators to apply this change in both.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)Java - @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)
TypeScript - @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)