Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-axios] [Java] Respect User Supplied Header Params #20032

Closed
wants to merge 7 commits into from

Conversation

ckoegel
Copy link
Contributor

@ckoegel ckoegel commented Nov 5, 2024

This PR moves the assignment of user supplied header parameters after the automatic OAS defined assignment. This allows the user to define a header parameter and have it be respected instead of overwritten. Changes were made to both the Java okhttp-gson and typescript-axios generators to apply this change in both.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Java - @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

TypeScript - @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

@ckoegel
Copy link
Contributor Author

ckoegel commented Nov 5, 2024

Do I need to run a command to allow this failing workflow to accept the changed test file? Or should I implement the test another way?

@joscha
Copy link
Contributor

joscha commented Nov 6, 2024

Intent lgtm, unsure about implications, so let's wait for @macjohnny to weigh in.

@macjohnny
Copy link
Member

Do I need to run a command to allow this failing workflow to accept the changed test file? Or should I implement the test another way?

this needs to be changed here:

- filename: "samples/client/petstore/java/okhttp-gson/src/test/java/org/openapitools/client/api/PetApiTest.java"

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@@ -0,0 +1,59 @@
<project>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be registered similar to

(cd samples/client/petstore/typescript-axios/builds/with-npm-version && mvn integration-test)

@macjohnny
Copy link
Member

@ckoegel please split this PR into two, one for the java generator and one for the typescript generator, so it is easier to revert in case things go wrong

@ckoegel
Copy link
Contributor Author

ckoegel commented Nov 6, 2024

@macjohnny
Closing this in favor of #20040 and #20042 which split this PR based on language

@ckoegel ckoegel closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants