Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] [Rust-Axum] Fix clippy warning #19920

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

linxGnu
Copy link
Contributor

@linxGnu linxGnu commented Oct 20, 2024

This PR fix some Clippy warnings in generated code.

Noted: I ran integration tests, no problem so far:

./bin/generate-samples.sh bin/configs/manual/rust-axum-*
mvn integration-test -f samples/server/petstore/rust-axum/pom.xml

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@linxGnu
Copy link
Contributor Author

linxGnu commented Oct 20, 2024

Kindly ping @wing328 to review. Thank you!

@linxGnu linxGnu mentioned this pull request Oct 20, 2024
5 tasks
@wing328 wing328 merged commit cfdb00a into OpenAPITools:master Oct 20, 2024
20 checks passed
@wing328
Copy link
Member

wing328 commented Oct 20, 2024

PR merged.

Have a nice weekend.

@wing328 wing328 added Server: Rust Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Oct 20, 2024
@wing328 wing328 added this to the 7.10.0 milestone Oct 20, 2024
@linxGnu linxGnu deleted the rust_axum_clippy_fix branch October 22, 2024 04:07
@linxGnu linxGnu restored the rust_axum_clippy_fix branch October 22, 2024 04:07
@linxGnu linxGnu deleted the rust_axum_clippy_fix branch October 22, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: Rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants