[OpenAPI 3.1] Avoid NPE when handling prefixItems #19735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
changed the title
6 tasks
joscha
reviewed
Oct 1, 2024
| @@ -622,6 +627,11 @@ public void testOpenAPINormalizerProcessingArraySchema31Spec() { | |||
| assertEquals(((Schema) schema6.getProperties().get("arrayOfStrings")).getItems().getTypes().contains("string"), true); | |||
| assertEquals(((Schema) schema6.getProperties().get("arrayOfStrings")).getItems().getType(), "string"); | |||
| assertEquals(((Schema) schema6.getProperties().get("arrayOfStrings")).getType(), "array"); | |||
|
|
|||
| Schema schema8 = openAPI.getComponents().getSchemas().get("ArrayWithPrefixItems"); | |||
| assertNotEquals(((Schema) schema8.getProperties().get("with_prefixitems")).getItems(), null); | |||
There was a problem hiding this comment.
OOI, why not:
Suggested change
| assertNotEquals(((Schema) schema8.getProperties().get("with_prefixitems")).getItems(), null); | |
| assertNotNull(((Schema) schema8.getProperties().get("with_prefixitems")).getItems()); |
?
There was a problem hiding this comment.
to me, it's much easier to read when comparing 2 values
There was a problem hiding this comment.
👍 Interesting, for me it's the opposite, scanning the assertion function first. Also, some of the convenience functions have more precise error messages in case the assertion fails, which I always appreciate whilst sorting out any messes I may have made :)
joscha
reviewed
Oct 1, 2024
| @@ -24,14 +24,14 @@ pub enum NumericEnumTesting { | |||
|
|
|||
| } | |||
|
|
|||
| impl ToString for NumericEnumTesting { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @OpenAPITools/generator-core-team
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)