[csharp][generichost][8.0.x] Fix operation parameter ordering #18830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly [fix OpenAPITools#18742] (OpenAPITools#18743) * fix serialization of OffsetDateTime * update samples * wrap import
Bumps [jorelali/setup-elm](https://github.com/jorelali/setup-elm) from 5 to 6. - [Release notes](https://github.com/jorelali/setup-elm/releases) - [Commits](JorelAli/setup-elm@v5...v6) --- updated-dependencies: - dependency-name: jorelali/setup-elm dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix bug referenced in OpenAPITools#18746 , introduced in OpenAPITools#18418 * Generate examples
* revert junit5 upgrade * revert upgrade to junit5 * fix kotlin-wiremock template folder * fix/comment tests * update
* add validteJsonElement * add oneOf support * various fixes, add tests * minor fixes * minor fixes * update data class * remove comments * array support, add test * update api client constructor * add anyOf support * add new files * fix merge * update * update * update * update
* added 4.8 samples * easer to understand diff * build samples again * build samples again
* Revert "Revert back to junit4 (OpenAPITools#18786)" This reverts commit 2471ba2. * Make junit engine execute TestNG test cases * Fix failing test and use tempDir's for test code generation * Make test fail with helpful info in case generator throws exception * Suppress error output from TestUtils * Remove transitive junit4 dependency * Sync guava-testlib version with guava version * Add hint regarding alternative for guava-testlib's FakeTicker
…penAPITools#18798) * Specify exact relative path to parent pom.xml * Remove org.reflections from the test stack * Remove unused parameter * Remove unused method * Fix raw use of parameterized variable warning * Use Files.readString instead of converting raw bytes * Add test coverage for TestUtils.validatePomXmlFiles(List) * Reimplement TestUtils.validatePomXmlFiles(List) with Jackson XML mapper * Remove maven-rewrite dependency
…eOnly=true (OpenAPITools#18809) * Fix kotlin-spring not building when `interfaceOnly=true` Fixes OpenAPITools#18803 * Regenerate fixed kotlin-spring samples * Include sample kotlin-springboot-request-cookie in CI build check * Apply suggestions from code review Co-authored-by: Stefan Koppier <[email protected]> --------- Co-authored-by: Stefan Koppier <[email protected]>
* List enum values in docs * Remove newline * Remove another newline * Generate samples
…meter generates a org::openapitools::server::model::std::optional<...> that doesn't compile OpenAPITools#18792 (OpenAPITools#18793) Solving this issue has for goal to reduce the amount of work required to resolve the [[C++] Error making the cpprestsdk generated files](OpenAPITools#6726) and to put the `cpp-pistache-server` generator a the "same compilation problems" level than the `cpp-restsdk` generator in font of the OpenAPITools#6726.
* add cpprest sdk test in circleci * install
) * [cpp-restsdk] add support for oneOf via std::variant * [cpp-restsdk] detect the latest supported C++ standard in CMake * [cpp-restsdk] add test with oneOf support for cpprest * [cpp-restsdk] avoid warnings because of implicit this capture * [cpp-restsdk] avoid deprecated CMake version warnings * [cpp-restsdk] build the test into the build directory - parallel build * [cpprest-sdk] use absolute source path for cmake + debug build * fix: remove inheritance due to template not overriding --------- Co-authored-by: William Cheng <[email protected]>
…Tools#18474)" (OpenAPITools#18820) This reverts commit 6a3d406.
devhl-labs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the order of operation parameters to alphabetical. This is usually what we would see in a C# method and matches our model constructors.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)