-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Update Java version in GitHub actions #18513
[Java] Update Java version in GitHub actions #18513
Conversation
@@ -7,40 +7,43 @@ PATH | |||
GEM | |||
remote: https://rubygems.org/ | |||
specs: | |||
ast (2.4.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR.
why are there changes to Gemfile.lock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI build was failing with the newer Ubuntu image. Probably because it has a newer version of Ruby (3.3.0) which is not compatible with Bundler 1.17.2. Deleting and re-generating the lockfiles helped.
Bundler 2.5.3 is running, but your lockfile was generated with 1.17.2. Installing Bundler 1.17.2 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 1.17.2
Installing bundler 1.17.2
/opt/circleci/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/bundler-1.17.2/lib/bundler/shared_helpers.rb:272:in `search_up': undefined method `untaint' for an instance of String (NoMethodError)
current = File.expand_path(SharedHelpers.pwd).untaint
^^^^^^^^
modules/openapi-generator/src/main/resources/Java/gradle-wrapper.properties.mustache
Show resolved
Hide resolved
thanks for the PR. let's give it a try 👍 |
For those who need to use a different version of gradle other than (gradle 8.7), please use customized templates instead (e.g. -t via CLI) |
The original issues were:
samples/client/petstore/java/resttemplate-jakarta
would not build locally using the gradle wrapper, since it was using an outdated version of Gradlesamples/client/petstore/java/resttemplate-jakarta
would not build in Github actions since it was using an outdated Java version 8Solution:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)