Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Update Java version in GitHub actions #18513

Merged

Conversation

ErkoRisthein
Copy link
Contributor

@ErkoRisthein ErkoRisthein commented Apr 26, 2024

The original issues were:

  1. samples/client/petstore/java/resttemplate-jakarta would not build locally using the gradle wrapper, since it was using an outdated version of Gradle
  2. samples/client/petstore/java/resttemplate-jakarta would not build in Github actions since it was using an outdated Java version 8

Solution:

  • Upgrade the Gradle wrapper to 8.7
  • Update the Java version to the currently supported LTS versions 17 and 21 in Github actions
  • Update CircleCI machines to ubuntu-2004:2024.01.1 which use Java 17
  • Use the gradle wrapper for samples-java-client-jdk17 in Github actions to prevent this issue from happening again

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@ErkoRisthein ErkoRisthein changed the title Update Java version in GitHub actions [Java] Update Java version in GitHub actions Apr 26, 2024
@@ -7,40 +7,43 @@ PATH
GEM
remote: https://rubygems.org/
specs:
ast (2.4.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.

why are there changes to Gemfile.lock?

Copy link
Contributor Author

@ErkoRisthein ErkoRisthein Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI build was failing with the newer Ubuntu image. Probably because it has a newer version of Ruby (3.3.0) which is not compatible with Bundler 1.17.2. Deleting and re-generating the lockfiles helped.

Bundler 2.5.3 is running, but your lockfile was generated with 1.17.2. Installing Bundler 1.17.2 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 1.17.2
Installing bundler 1.17.2
/opt/circleci/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/bundler-1.17.2/lib/bundler/shared_helpers.rb:272:in `search_up': undefined method `untaint' for an instance of String (NoMethodError)

      current  = File.expand_path(SharedHelpers.pwd).untaint
                                                    ^^^^^^^^

https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/29141/workflows/2723157b-b3c5-40ff-a8eb-48567400b615/jobs/93653

@wing328 wing328 added this to the 7.6.0 milestone Apr 28, 2024
@wing328 wing328 merged commit bd02e65 into OpenAPITools:master Apr 30, 2024
96 checks passed
@wing328
Copy link
Member

wing328 commented Apr 30, 2024

thanks for the PR. let's give it a try 👍

@wing328
Copy link
Member

wing328 commented Apr 30, 2024

For those who need to use a different version of gradle other than (gradle 8.7), please use customized templates instead (e.g. -t via CLI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants