Improve camelization for words starting with acronym #18218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/timcbaoth/openapi-generator into timcbaoth-improve-camlization-in-default-codegen
6 tasks
wing328
changed the title
wing328
commented
Mar 24, 2024
...rp-netcore/OpenAPIClient-generichost-net6.0-nrt/src/Org.OpenAPITools/Model/Capitalization.cs
Outdated
Show resolved
Hide resolved
devhl-labs
reviewed
Mar 24, 2024
| result = result.substring(0, 1).toLowerCase(Locale.ROOT) + result.substring(1); | ||
| if (Boolean.parseBoolean(System.getProperty("openapi.generator.fix.camelize"))) { | ||
| // new behaviour with fix | ||
| String[] splitString = name.split(nonNameElementPattern); |
There was a problem hiding this comment.
Can you change it to this so that it does not mutate the string in unintended ways? We just want to change casing, not strip whitespace.
String[] splitString = name.split(nonNameElementPattern, -1);
devhl-labs
reviewed
Mar 24, 2024
| } | ||
|
|
||
| String result = Arrays.stream(splitString) | ||
| .map(StringUtils::capitalize) |
There was a problem hiding this comment.
Why would we capitalize splitString[0] when we just used camelize with lower case first?
devhl-labs
reviewed
Mar 24, 2024
| @@ -257,6 +258,13 @@ void configureGeneratorProperties() { | |||
| System.out.println(SerializerUtils.toJsonString(openAPI)); | |||
| } | |||
|
|
|||
| // check to see if we need to apply camelize fix | |||
| if (config.additionalProperties().containsKey("applyCamelizeFix")) { | |||
There was a problem hiding this comment.
If we think the new method is better, then we should make it enabled by default with an option to opt out and use the legacy method.
There was a problem hiding this comment.
i want to let users to try it out first to see if we've other edge cases not yet handled.
plan to flip the switch in the upcoming v8.0.0 release.
…amlization-in-default-codegen
…amlization-in-default-codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--additional-properties applyCamelizeFix=truein CLIPR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)