[R][Client] Allow api responses to be NULL or invalid JSON and fix file_params for file upload #18108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)Introduces changes:
ApiResponse now deserializes NULL values instead of producing errors by turning them into strings "NULL"
ApiClient now allows to deserialize responses not conforming to JSON, i.e. a simple string would normally produce an error in
jsonlite::fromJSON
but will now be passed on unchanged.api.mustache
file_params["{{baseName}}"]
has been changed tofile_params[["{{baseName}}"]]
in order to function as intended when a file path is given asparamName
infile_params[["{{baseName}}"]] <- curl::form_file(`{{paramName}}`)
Technical committee @Ramanth @saigiridhar21