Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18090 Insert missing quote in clientPropertiesConfiguration.mustache for the Spring generator #18091

Conversation

larsenf-els
Copy link
Contributor

@larsenf-els larsenf-els commented Mar 13, 2024

Bug fix for #18090: [BUG] Spring generator (7.4.0): Generated ClientPropertiesConfiguration constructor gives compiler error

Insert missing quote: {{{tokenUrl}}}" -> "{{{tokenUrl}}}" in the clientPropertiesConfiguration.mustache used by the Spring Generator.

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.5.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@larsenf-els larsenf-els marked this pull request as ready for review March 13, 2024 10:13
@MelleD
Copy link
Contributor

MelleD commented Mar 13, 2024

@larsenf-els nice catch, thanks for the PR. Could you also add a test for the bugfix 👍

@larsenf-els
Copy link
Contributor Author

@larsenf-els nice catch, thanks for the PR. Could you also add a test for the bugfix 👍

Will do. :D

@larsenf-els
Copy link
Contributor Author

@larsenf-els Could you also add a test for the bugfix 👍

I have now added a unit test. I tested this with and without the fix in the clientPropertiesConfiguration.mustache file.

@MelleD
Copy link
Contributor

MelleD commented Mar 14, 2024

@larsenf-els thanks

@wing328 can be merged :)

@wing328
Copy link
Member

wing328 commented Mar 16, 2024

@larsenf-els thanks for the PR but the CI tests failed. Can you please fix it when you've time?

Ping me via Slack if you need help.

@wing328
Copy link
Member

wing328 commented Mar 20, 2024

merged via #18172 with a fix in the test

@wing328 wing328 closed this Mar 20, 2024
@larsenf-els larsenf-els deleted the fix-missing-quote-clientPropertiesConfiguration.mustache-7.4.0 branch May 16, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants