-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parameters_to_url_query returns booleans with upper letter #16947
fix parameters_to_url_query returns booleans with upper letter #16947
Conversation
Fix for #16941 |
if isinstance(v, bool): | ||
v = str(v).lower() | ||
if isinstance(v, (int, float)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In python boolean is a subclass of int so isinstance(True, (int, float)) == True
. We need to check if the type is boolean before checking if the type is a number to get the behaviour we desire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In python boolean is a subclass of int so
isinstance(True, (int, float)) == True
. We need to check if the type is boolean before checking if the type is a number to get the behaviour we desire.
TIL it's still the case in Python 3, I thought this was only the case in 2.x 👍
@mhaley-tignis thanks for the PR. Can you please take a look at the test failure when you've time? |
whoops, yes, missed that |
7910751
to
261268c
Compare
ok @wing328, should be good now. I rushed this and didn't really look at the exception the first time. Sorry about that! |
no need to sorry and thanks for your PR to improve the Python client generator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the fix @mhaley-tignis !
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)