-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][okhttp-gson] validateJsonElement does not validate enum values #16865
[Java][okhttp-gson] validateJsonElement does not validate enum values #16865
Conversation
0f40188
to
f08bf33
Compare
f08bf33
to
6c1d6bb
Compare
Please merge the latest master as I've just merged #16985 to restore some tests. Please add a test in JSONTest.java to ensure this issue is covered moving forward. Let me know if you need any help. |
0892f27
to
ab3a2e1
Compare
@wing328 I added a test and it passed in CI but a different workflow failed because the digest of the Did I update the test file in the wrong way? Or should I manually update the SHA in |
yes please update that as the hash is no longer the same |
ab3a2e1
to
e875cf6
Compare
@@ -0,0 +1,123 @@ | |||
{{#jackson}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you've time, can you please file another PR to clean up {{#jackson}} ... {{/jackson}} in this file as okhttp-gson library doesn't use the jackson mustache tag?
(and we don't need the gson tag either as it must be true when using okhttp-gson)
This PR adds enum templates for Java with
okhttp-gson
to addvalidateJsonElement
functions to both inline enums and external enums, and to call thevalidateJsonElement
function for enum properties.Fixes #16917
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)cc/ @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)