Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RPMSG buffer address translation out of VirtIO layer #575

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move RPMSG buffer address translation out of VirtIO layer #575

wants to merge 2 commits into from
+34 −52

Commits on Mar 19, 2024

  1. virtqueue: Fix comment on shm_io and fix type 

    This should hold a pointer to an metal_io_region, make that the type.

Also fix the comment, this region holds the address of the message
buffers, not the vring's descriptor table nor available/used rings.
It is only used for virt-to-phys/phys-to-vert on the buffers pointed
to by these descriptors.

This comment seems to have cause an issue in virtio_mmio_drv where
this region was used to translate the address of the vring descriptors.
This may have worked if the vring descriptors where part of the same
IO space as the buffers they point to, but this is not guaranteed
to always be the case. Fix that here.

Signed-off-by: Andrew Davis <[email protected]>
    @glneo
    glneo committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3dbbb25 View commit details
    Browse the repository at this point in the history

  2. virtio: Use physical addresses for buffers in virtio 

    Have the higher level rpmsg_virtio handle the virt-to-phys and back
conversion. The rpmsg_virtio layer already has the shared buffer memory
metal IO. This removes the need to pass in the buffer region metal_io
struct down to the virtio layer, which otherwise does nothing with the
contents of the buffers.

Signed-off-by: Andrew Davis <[email protected]>
    @glneo
    glneo committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e05c41a View commit details
    Browse the repository at this point in the history