Merge pull request #16 from Open-Systems-Pharmacology/getbaseunit-par…

…ameter-fix

Remove `dimension` parameter in `ospsuite::getBaseUnit`

R/output.R

@@ -23,7 +23,7 @@ SAOutput <- R6::R6Class(
 
       self$dimension <- ospQuantity$dimension
 
-      self$unit <- unit %||% ospsuite::getBaseUnit(dimension = self$dimension)
+      self$unit <- unit %||% ospsuite::getBaseUnit(self$dimension)
 
       if (self$unit == "Unitless") {
         self$unit <- ""

R/parameter.R

@@ -32,7 +32,7 @@ SAParameter <- R6::R6Class(
 
       self$dimension <- ospParameter$dimension
 
-      self$unit <- unit %||% ospsuite::getBaseUnit(dimension = self$dimension)
+      self$unit <- unit %||% ospsuite::getBaseUnit(self$dimension)
 
       if (self$unit == "Unitless") {
         self$unit <- ""

tests/testthat/test-SAOutput.R

@@ -0,0 +1,17 @@
+simPath <- system.file("extdata", "Aciclovir.pkml", package = "ospsuite")
+simulation <- loadSimulation(simPath)
+outputPath <- "Organism|PeripheralVenousBlood|Aciclovir|Plasma (Peripheral Venous Blood)"
+parameterPath <- c("Aciclovir|Lipophilicity")
+
+test_that("SAOutput object can be created with default settings", {
+  expect_no_error(
+    SAOutputTest <- SAOutput$new(
+      simulation = simulation,
+      path = outputPath
+    )
+  )
+  expect_s3_class(SAOutputTest, "R6")
+  expect_equal(SAOutputTest$path, outputPath)
+  expect_equal(SAOutputTest$displayName, outputPath)
+  expect_null(SAOutputTest$pkParameterList)
+})

tests/testthat/test-SAParameter.R

@@ -0,0 +1,16 @@
+simPath <- system.file("extdata", "Aciclovir.pkml", package = "ospsuite")
+simulation <- loadSimulation(simPath)
+parameterPath <- c("Aciclovir|Lipophilicity")
+
+test_that("SAParameter object can be created with default settings", {
+  expect_no_error(
+    SAParameterTest <- SAParameter$new(
+      simulation = simulation,
+      path = parameterPath
+    )
+  )
+  expect_s3_class(SAParameterTest, "R6")
+  expect_equal(SAParameterTest$path, parameterPath)
+  expect_equal(SAParameterTest$displayName, parameterPath)
+  expect_equal(SAParameterTest$unit, "Log Units")
+})