Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2115 error when importing empty row #2384

Merged

Conversation

benjaperez1983
Copy link
Contributor

Fixes #2115

Description

Error when importing a sheet with an empty row

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

Copy link
Member

@rwmcintosh rwmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to merge into 12.1 instead of develop so that it does not merge to v12.

Changes needed -> change PR target branch

Other comments are for discussion, or for your consideration.

@benjaperez1983 benjaperez1983 changed the base branch from develop to 12.Next January 8, 2025 10:41
@rwmcintosh rwmcintosh requested review from msevestre and Yuri05 January 8, 2025 14:57
@rwmcintosh rwmcintosh merged commit 0c46b07 into 12.Next Jan 10, 2025
1 check passed
@rwmcintosh rwmcintosh deleted the 2115-error-when-importing-a-sheet-with-an-empty-row branch January 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when importing a sheet with an empty row
3 participants