-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement getMolWeightFor()
to work with Quantity
#1501
Conversation
@Felixmil @rwmcintosh I forgot how it works now with the core files - they are updated automatically? Should they be part of the PR? |
25beaf8
to
899e3fe
Compare
Yes, they are retrieved from latest pksim build and commit to the PR's branch by a github action: |
Just learned that there will be a problem pulling the core files when the package is loaded |
Yes, because they are in use. Restarting the R session is necessary. We should also update the |
Sure, makes sense to restart, but one might not consider it during the first time.
Yes, makes sense to restart before pulling the core files while working on the PR. But Do I miss something - how is changing |
getMolWeightFor()
retrieves the molecular weight of a quantity's (parent) molecule, returning it in the specified unit.Returns NA if no molecule is found, or throws an error if stopIfNotFound = TRUE.
Utilizes helper
.getParentContainerByType
which allows to get the parent container of a quantity by type.Closes #1500