-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to not run simulations when converting snapshots #1488
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
17e1381
update core files
Felixmil fad9a0a
Add argument to run simulations or not during conversion
Felixmil 9f231bb
fix typo
Felixmil d933676
🤖 Update Core Files.
github-actions[bot] b0374f8
update the json for consistency
rwmcintosh f19430d
temporary disable core files updates in github actions
Felixmil 41af041
update core files manually
Felixmil f7efa7e
manually update core files
Felixmil 684b096
add details
Felixmil c0264dd
Add test for RunSimulations argument
Felixmil f079d3f
Restore core files update during github workflow
Felixmil 42ee414
Manually update Core files
Felixmil ab86cd2
fix pluralization
Felixmil 7caa968
print whole error if message could not be extracted
Felixmil ba6d736
🤖 Update Core Files.
github-actions[bot] 88706a9
fix typo
Felixmil 65b4179
Merge branch 'convert-snapshot-dont-run-simulations' of https://githu…
Felixmil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some error messages won't have a message line of format "Message: *". In this case
str_extract()
returns in NA resulting inThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I added an if case to handle this.