Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20/10/2022]Task 3 add-on Feat/OSCSA all event page #196

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sandygudie
Copy link
Member

@sandygudie sandygudie commented Oct 20, 2022

Summary

Issue: #195
This PR is an add-on to Task 3.2 #187. A user can view all-event page when they click the "More OSCSA events" on the home page.

Fixes #

  • Added an all-events subpage
  • The page has a section for upcoming events section( sample list shown below)
  • Added the Arabic version of the page
  • Ensured the page is responsive

Result Sample:
image
image
image

List of changes proposed in this PR (pull-request)

A better OSCSA event Image
Improve content

What should a reviewer concentrate their feedback on?

To Review the page add /event-listing/events.html to the Home page URL

  • Everything looks ok?

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for oscksa ready!

Name Link
🔨 Latest commit 18d2484
🔍 Latest deploy log https://app.netlify.com/sites/oscksa/deploys/63551d6567f5d20008e02d32
😎 Deploy Preview https://deploy-preview-196--oscksa.netlify.app/event-listing/ar-events
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sandygudie
Copy link
Member Author

@BatoolMM The all event page mentioned in PR #187
Please review

@sandygudie sandygudie changed the title [20/10/2022]Task 3.2 Feat/added oscsa event page [20/10/2022]Task 3 add-on Feat/OSCSA all event page Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant