Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding contribution.md for contribution guidelines #173

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

jesutobi
Copy link
Contributor

@jesutobi jesutobi commented Oct 15, 2022

@alswajiab @BatoolMM there was conflict on that branch , which was preventing its merge, trying to resolve it now by creating a new pull request.
fixes #125
This is a contribution .md file that helps new contributors find it easy to contribute to OSCSA website

@netlify
Copy link

netlify bot commented Oct 15, 2022

Deploy Preview for oscksa ready!

Name Link
🔨 Latest commit 1ba275f
🔍 Latest deploy log https://app.netlify.com/sites/oscksa/deploys/63545de6c4269b0008e611a4
😎 Deploy Preview https://deploy-preview-173--oscksa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jesutobi
Copy link
Contributor Author

@BatoolMM good evening , my pull request hasn't been reviewed since i made corrections to it, i dont know what to do next

Copy link
Member

@BatoolMM BatoolMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the way you have written the contribution guidelines - there is minor corrections if you can go through them. Thank you so much!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@BatoolMM BatoolMM changed the title created a contribution.md file Adding contribution.md for contribution guidelines Oct 22, 2022
@BatoolMM BatoolMM added the documentation Improvements or additions to documentation label Oct 22, 2022
jesutobi and others added 22 commits October 22, 2022 22:06
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
commiting the suggestions made by my mentor

Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
@jesutobi
Copy link
Contributor Author

I love the way you have written the contribution guidelines - there is minor corrections if you can go through them. Thank you so much!

Thank you for your time, i have also resolved all the suggested changes

Copy link
Contributor Author

@jesutobi jesutobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BatoolMM i have made changes to the ones you suggested, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating a Contribution.md file
2 participants