Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the navigation bar #15

Closed
wants to merge 0 commits into from

Conversation

Mublin
Copy link

@Mublin Mublin commented Oct 9, 2022

corrected the navigation bar transition which works with the scroll of window listener and added a little styling to the navbar component. I am one if the interns from outreachy and blog section is coming soon

@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for oscksa ready!

Name Link
🔨 Latest commit 57c364e
🔍 Latest deploy log https://app.netlify.com/sites/oscksa/deploys/6357b373aee9920008d31984
😎 Deploy Preview https://deploy-preview-15--oscksa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Author

@Mublin Mublin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a blog section, check the model if you like it, I will try and add some transitions too

Copy link
Author

@Mublin Mublin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #12 and #87

I added the Events in the nav bar onclick it takes you to the event subpage I created

I added three cards with each event, title, the name of the speaker, date and language in the event subpage

I added the click event when clicking on the cards it take you to the Zenodo website where the slides are;

I also added the same events in both English and Arabic version of the website

@BatoolMM
Copy link
Member

Thank you @Mublin for your hard work. You are addressing multiple issues in a single PR. Can you make a single PR for correcting the navigation bar transition - and leave the blog section which has already been worked on using a different PR, please?

@BatoolMM BatoolMM added the bug Something isn't working label Oct 24, 2022
@Mublin Mublin closed this Oct 25, 2022
@Mublin
Copy link
Author

Mublin commented Oct 25, 2022

Thank you i have done the corrections in #210 @BatoolMM thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working outreachy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants