Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task2: About-Us dropdown /Code of Coduct subpage #115

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Task2: About-Us dropdown /Code of Coduct subpage #115

wants to merge 10 commits into from

Conversation

sandygudie
Copy link
Member

@sandygudie sandygudie commented Oct 11, 2022 •
edited
Loading

Summary: Task 2

  • Add a drop-down for About us. In the dropdown, we want to add:
    2.1 Who are we? (This will direct you to the same about us page on the website)
    2.2 Code of Conduct( This will direct you to a new subpage with the code of conduct
  • Make sure it's reflected on both the Arabic and English pages.
  • Multiple issues are open for this task. PR addresses issues 12
  • Alternative approach

Fixes #

  • I added About-us dropdown on the nav link with "who we are" and "Code of Conduct" as sublinks.
  • Users click on "Who are we?" to access the about us page.
  • Users click on "Code of Conduct" sublink to access the Code of Conduct subpage.
  • I added the code of conduct Arabic subpage, users can toggle between the Arabic and English pages.
  • I ensured responsiveness on both pages.
  • I ensured smooth navigation on both pages.
  • I fix content errors (punctuation etc)

Proposed changes in this PR (pull request)

  • None in mind for now

What should a reviewer concentrate their feedback on?

  • The overall view(UI), look and feel.
  • Page accessibility, are you able to navigate around?
  • Everything looks ok?

Page view
image

@sandygudie
added task2:code of conduct
64179e7
@sandygudie
Merge branch 'main' of https://github.com/sandygudie/OSCSA_Website in…
82c029a 
…to task2/dropdown-about-page
@sandygudie
Added Task2: About-us dropdown and code of conduct.
246009d 
- Added about-us dropdown on the homepage.
- Added code of conduct subpage with apprioprate navigation.
- Added the corresponding Arabic page for code of conduct with
  appropriate navigation.
- Ensured pages responsiveness.
@netlify
Copy link

netlify bot commented Oct 11, 2022 •
edited
Loading

✅ Deploy Preview for oscksa ready!

Name Link
🔨 Latest commit a447821
🔍 Latest deploy log https://app.netlify.com/sites/oscksa/deploys/63627cc6d11687000877e2dd
😎 Deploy Preview https://deploy-preview-115--oscksa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@okerekechinweotito
Copy link

okerekechinweotito commented Oct 11, 2022 •
edited
Loading

@sandygudie @BatoolMM The issue (#12 TASK 2) referenced here for this PR has been clearly addressed in #99 with the Arabic version included and responsive fixes perfected. Pls this is a duplicate

@BatoolMM BatoolMM added outreachy duplicate This issue or pull request already exists labels Oct 12, 2022
@alswajiab alswajiab mentioned this pull request Oct 16, 2022
Open
13 tasks
JesperKawuma
JesperKawuma reviewed Oct 18, 2022
View reviewed changes
Copy link

@JesperKawuma JesperKawuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sandygudie, this is really nice. I would also want to implement the same but it seems I don't understand these issues. When do I know that I have to add an Arabic file? But this is nice thanks

@sandygudie
Copy link
Member Author

Hello @sandygudie, this is really nice. I would also want to implement the same but it seems I don't understand these issues. When do I know that I have to add an Arabic file? But this is nice thanks

Thank you @JesperKawuma every page must have it's Arabic file, if you toggle the icon below, you would see the Arabic version of the home page
image

@JesperKawuma
Copy link

Ok, rhank you @sandygudie for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesperKawuma JesperKawuma JesperKawuma left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists outreachy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandygudie @okerekechinweotito @JesperKawuma @BatoolMM