Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo part of 02999a0 #2588

Merged
merged 1 commit into from
Dec 18, 2024
Merged

undo part of 02999a0 #2588

merged 1 commit into from
Dec 18, 2024

Conversation

ReimarBauer
Copy link
Member

@ReimarBauer ReimarBauer commented Dec 10, 2024 •
edited
Loading

Purpose of PR?:

None should not become str 'None'
Fixes #2586

@ReimarBauer ReimarBauer linked an issue Dec 10, 2024 that may be closed by this pull request
type casting of None in models.Changes to 'None' is wrong #2586
Closed
@ReimarBauer ReimarBauer mentioned this pull request Dec 10, 2024
Draft
matrss
matrss requested changes Dec 13, 2024
View reviewed changes
mslib/mscolab/models.py Outdated Show resolved Hide resolved
matrss
matrss reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But shouldn't this target stable, as the issue exists there too? Also, should a migration script be included that fixes wrongly created database entries?

@ReimarBauer
Copy link
Member Author

Absolutly. My fault. I thought I introduced that shortly.

@ReimarBauer ReimarBauer changed the base branch from develop to stable December 16, 2024 15:17
@ReimarBauer ReimarBauer mentioned this pull request Dec 16, 2024
Open
@ReimarBauer
Copy link
Member Author

ReimarBauer commented Dec 16, 2024 •
edited
Loading

@matrss The migration will be adressed later.
#2590

With the old solution a migration is rather ugly and I don't want to add a new function which is in the next major pointless.

Also that it is now handled "None" here as string did not crash our usecases.

@ReimarBauer ReimarBauer merged commit b2d2089 into Open-MSS:stable Dec 18, 2024
8 of 11 checks passed
@ReimarBauer ReimarBauer deleted the i2586 branch December 18, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrss matrss matrss approved these changes

Assignees

@matrss matrss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type casting of None in models.Changes to 'None' is wrong
2 participants
@ReimarBauer @matrss