Add Fullname and Nickname Feature to User Profiles

mslib/index.py

@@ -81,7 +81,6 @@ def create_app(name="", imprint=None, gdpr=None):
 
     @APP.route('/xstatic/<name>/<path:filename>')
     def files(name, filename):
-
         base_path = _xstatic(name)
         if base_path is None:
             abort(404)
@@ -96,10 +95,6 @@ def mss_theme(filename):
 
     APP.jinja_env.globals.update(get_topmenu=get_topmenu)
 
-    @APP.route("/index")
-    def index():
-        return render_template("/index.html")
-
     @APP.route("/mss/about")
     @APP.route("/mss")
     def about():

mslib/mscolab/file_manager.py

@@ -223,41 +223,32 @@ def modify_user(self, user, attribute=None, value=None, action=None):
         if action == "create":
             user_query = User.query.filter_by(emailid=str(user.emailid)).first()
             if user_query is None:
+                if not user.fullname:
+                    raise ValueError("Full name must be provided.")
                 db.session.add(user)
                 db.session.commit()
             else:
                 return False
         elif action == "delete":
             user_query = User.query.filter_by(id=user.id).first()
             if user_query is not None:
-                # Delete profile image if it exists
-                if user.profile_image_path:
-                    self.delete_user_profile_image(user.profile_image_path)
                 db.session.delete(user)
                 db.session.commit()
             user_query = User.query.filter_by(id=user.id).first()
-            # on delete we return successful deleted
             if user_query is None:
                 return True
-        elif action == "update_idp_user":
-            user_query = User.query.filter_by(emailid=str(user.emailid)).first()
-            if user_query is not None:
-                db.session.add(user)
-                db.session.commit()
-            else:
+        elif action == "update_fullname":
+            user_query = User.query.filter_by(id=user.id).first()
+            if user_query is None:
                 return False
-        user_query = User.query.filter_by(id=user.id).first()
-        if user_query is None:
-            return False
-        if None not in (attribute, value):
-            if attribute == "emailid":
-                user_query = User.query.filter_by(emailid=str(value)).first()
-                if user_query is not None:
-                    return False
-            setattr(user, attribute, value)
-            db.session.commit()
+            if value is not None:
+                if not value.strip():
+                    raise ValueError("Full name cannot be empty.")
+                setattr(user, "fullname", value)
+                db.session.commit()
         return True
 
+
     def delete_user_profile_image(self, image_to_be_deleted):
         '''
         This function is called when deleting account or updating the profile picture

mslib/mscolab/migrations/versions/922e4d9c94e2_to_version_10_0_0.py

@@ -21,6 +21,9 @@ def upgrade():
     # ### commands auto generated by Alembic - please adjust! ###
     with op.batch_alter_table('users', schema=None) as batch_op:
         batch_op.add_column(sa.Column('profile_image_path', sa.String(length=255), nullable=True))
+
+    with op.batch_alter_table('users', schema=None) as batch_op:
+        batch_op.add_column(sa.Column('fullname', sa.String(length=255), nullable=True))
 
     # ### end Alembic commands ###
 
@@ -30,4 +33,7 @@ def downgrade():
     with op.batch_alter_table('users', schema=None) as batch_op:
         batch_op.drop_column('profile_image_path')
 
-    # ### end Alembic commands ###
+    with op.batch_alter_table('users', schema=None) as batch_op:
+        batch_op.drop_column('fullname')
+
+     # ### end Alembic commands ###

mslib/mscolab/models.py

@@ -64,9 +64,10 @@ class User(db.Model):
     confirmed_on = db.Column(AwareDateTime, nullable=True)
     permissions = db.relationship('Permission', cascade='all,delete,delete-orphan', backref='user')
     authentication_backend = db.Column(db.String(255), nullable=False, default='local')
+    fullname = db.Column(db.String(255), nullable=True)
 
     def __init__(self, emailid, username, password, profile_image_path=None, confirmed=False,
-                 confirmed_on=None, authentication_backend='local'):
+                 confirmed_on=None, authentication_backend='local', fullname=""):
         self.username = str(username)
         self.emailid = str(emailid)
         self.hash_password(password)
@@ -75,6 +76,7 @@ def __init__(self, emailid, username, password, profile_image_path=None, confirm
         self.confirmed = bool(confirmed)
         self.confirmed_on = confirmed_on
         self.authentication_backend = str(authentication_backend)
+        self.fullname = str(fullname)
 
     def __repr__(self):
         return f'<User {self.username}>'

mslib/mscolab/server.py

@@ -248,9 +248,9 @@ def check_login(emailid, password):
     return False
 
 
-def register_user(email, password, username):
-    if len(str(email.strip())) == 0 or len(str(username.strip())) == 0:
-        return {"success": False, "message": "Your username or email cannot be empty"}
+def register_user(email, password, username, fullname):
+    if len(str(email.strip())) == 0 or len(str(username.strip())) == 0 or len(str(fullname.strip())) == 0 :
+        return {"success": False, "message": "Your username, fullname or email cannot be empty"}
     is_valid_username = True if username.find("@") == -1 else False
     is_valid_email = validate_email(email)
     if not is_valid_email:
@@ -263,11 +263,10 @@ def register_user(email, password, username):
     user_exists = User.query.filter_by(username=str(username)).first()
     if user_exists:
         return {"success": False, "message": "This username is already registered"}
-    user = User(email, username, password)
+    user = User(email, username, password, fullname)
     result = fm.modify_user(user, action="create")
     return {"success": result}
 
-
 def verify_user(func):
     @functools.wraps(func)
     def wrapper(*args, **kwargs):
@@ -405,7 +404,8 @@ def user_register_handler():
     email = request.form['email']
     password = request.form['password']
     username = request.form['username']
-    result = register_user(email, password, username)
+    fullname = request.form['fullname']
+    result = register_user(email, password, username, fullname)
     status_code = 200
     try:
         if result["success"]:
@@ -616,6 +616,37 @@ def set_version_name():
     return jsonify({"success": True, "message": "Successfully set version name"})
 
 
+@APP.route("/edit_user_info", methods=["POST"])
+@verify_user
+def edit_user_info():
+    user = g.user
+    fullname = request.form.get("fullname")
+
+    try:
+        # Update the user's full name in the database
+        user_record = User.query.filter_by(id=int(user.id)).first()
+        if user_record is None:
+            return jsonify({"success": False, "error": "User not found."}), 404
+
+        # Update the full name
+        user_record.fullname = fullname  # Update full name
+
+        # Commit changes to the database
+        _handle_db_upgrade().session.commit() 
+        return jsonify({
+            "success": True,
+            "fullname": user_record.fullname  # Return the updated full name
+        }), 200
+
+    except Exception as e:
+        logging.debug(f"Error updating user info: {str(e)}")
+        return jsonify({
+            "success": False,
+            "error": "Failed to update user info"
+        }), 500
+
+
+
 @APP.route('/authorized_users', methods=['GET'])
 @verify_user
 def authorized_users():
@@ -1027,3 +1058,4 @@ def main():
 
 if __name__ == '__main__':
     main()
+

mslib/msui/mscolab.py

@@ -966,6 +966,31 @@ def delete_account(self, _=None):
             if r.status_code == 200 and json.loads(r.text)["success"] is True:
                 self.logout()
 
+    @verify_user_token
+    def editfull_name(self):
+        fullname, ok = QtWidgets.QInputDialog.getText(
+        self.ui,
+        self.ui.tr("Edit Full Name"),
+        self.ui.tr("Enter new full name:")  
+    )
+
+        if ok:
+            data = {
+                "token": self.token,
+                "fullname": str(fullname)  
+        }
+            url = urljoin(self.mscolab_server_url, 'edit_full_name')  
+            r = requests.post(url, data=data)
+
+            if r.text == "true":
+                self.error_dialog = QtWidgets.QErrorMessage()
+                self.error_dialog.showMessage("Fullname is updated successfully.")
+                self.profile_dialog.fullname_label2.setText(self.user["fullname"])
+
+
+    def editnick_name(self):
+        pass
+
     @verify_user_token
     def add_operation_handler(self, _=None):
         def check_and_enable_operation_accept():

mslib/msui/qt5/ui_add_user_dialog.py

@@ -1,52 +1,66 @@
 # -*- coding: utf-8 -*-
 
-# Form implementation generated from reading ui file 'mslib/msui/ui/ui_add_user.ui'
+# Form implementation generated from reading ui file 'ui_add_user_dialog.ui'
 #
-# Created by: PyQt5 UI code generator 5.9.2
+# Created by: PyQt5 UI code generator 5.15.9
 #
-# WARNING! All changes made in this file will be lost!
+# WARNING: Any manual changes made to this file will be lost when pyuic5 is
+# run again.  Do not edit this file unless you know what you are doing.
+
 
 from PyQt5 import QtCore, QtGui, QtWidgets
 
+
 class Ui_addUserDialog(object):
     def setupUi(self, addUserDialog):
         addUserDialog.setObjectName("addUserDialog")
-        addUserDialog.resize(375, 232)
+        addUserDialog.resize(375, 293)
         self.gridLayout = QtWidgets.QGridLayout(addUserDialog)
         self.gridLayout.setObjectName("gridLayout")
         self.verticalLayout = QtWidgets.QVBoxLayout()
         self.verticalLayout.setObjectName("verticalLayout")
         self.formLayout = QtWidgets.QFormLayout()
         self.formLayout.setFieldGrowthPolicy(QtWidgets.QFormLayout.ExpandingFieldsGrow)
         self.formLayout.setLabelAlignment(QtCore.Qt.AlignRight|QtCore.Qt.AlignTrailing|QtCore.Qt.AlignVCenter)
+        self.formLayout.setHorizontalSpacing(7)
         self.formLayout.setVerticalSpacing(14)
         self.formLayout.setObjectName("formLayout")
+        self.usernameLabel = QtWidgets.QLabel(addUserDialog)
+        self.usernameLabel.setObjectName("usernameLabel")
+        self.formLayout.setWidget(1, QtWidgets.QFormLayout.LabelRole, self.usernameLabel)
         self.username = QtWidgets.QLineEdit(addUserDialog)
         self.username.setObjectName("username")
         self.formLayout.setWidget(1, QtWidgets.QFormLayout.FieldRole, self.username)
+        self.fullnamelabel = QtWidgets.QLabel(addUserDialog)
+        self.fullnamelabel.setObjectName("fullnamelabel")
+        self.formLayout.setWidget(2, QtWidgets.QFormLayout.LabelRole, self.fullnamelabel)
+        self.fullname = QtWidgets.QLineEdit(addUserDialog)
+        self.fullname.setText("")
+        self.fullname.setObjectName("fullname")
+        self.formLayout.setWidget(2, QtWidgets.QFormLayout.FieldRole, self.fullname)
+        self.emailIDLabel = QtWidgets.QLabel(addUserDialog)
+        self.emailIDLabel.setObjectName("emailIDLabel")
+        self.formLayout.setWidget(3, QtWidgets.QFormLayout.LabelRole, self.emailIDLabel)
         self.emailid = QtWidgets.QLineEdit(addUserDialog)
         self.emailid.setObjectName("emailid")
-        self.formLayout.setWidget(2, QtWidgets.QFormLayout.FieldRole, self.emailid)
+        self.formLayout.setWidget(3, QtWidgets.QFormLayout.FieldRole, self.emailid)
         self.passwordLabel = QtWidgets.QLabel(addUserDialog)
         self.passwordLabel.setObjectName("passwordLabel")
-        self.formLayout.setWidget(3, QtWidgets.QFormLayout.LabelRole, self.passwordLabel)
+        self.formLayout.setWidget(4, QtWidgets.QFormLayout.LabelRole, self.passwordLabel)
         self.password = QtWidgets.QLineEdit(addUserDialog)
         self.password.setEchoMode(QtWidgets.QLineEdit.Password)
         self.password.setObjectName("password")
-        self.formLayout.setWidget(3, QtWidgets.QFormLayout.FieldRole, self.password)
+        self.formLayout.setWidget(4, QtWidgets.QFormLayout.FieldRole, self.password)
         self.confirmPasswordLabel = QtWidgets.QLabel(addUserDialog)
         self.confirmPasswordLabel.setObjectName("confirmPasswordLabel")
-        self.formLayout.setWidget(4, QtWidgets.QFormLayout.LabelRole, self.confirmPasswordLabel)
+        self.formLayout.setWidget(5, QtWidgets.QFormLayout.LabelRole, self.confirmPasswordLabel)
         self.rePassword = QtWidgets.QLineEdit(addUserDialog)
         self.rePassword.setEchoMode(QtWidgets.QLineEdit.Password)
         self.rePassword.setObjectName("rePassword")
-        self.formLayout.setWidget(4, QtWidgets.QFormLayout.FieldRole, self.rePassword)
-        self.emailIDLabel = QtWidgets.QLabel(addUserDialog)
-        self.emailIDLabel.setObjectName("emailIDLabel")
-        self.formLayout.setWidget(2, QtWidgets.QFormLayout.LabelRole, self.emailIDLabel)
-        self.usernameLabel = QtWidgets.QLabel(addUserDialog)
-        self.usernameLabel.setObjectName("usernameLabel")
-        self.formLayout.setWidget(1, QtWidgets.QFormLayout.LabelRole, self.usernameLabel)
+        self.formLayout.setWidget(5, QtWidgets.QFormLayout.FieldRole, self.rePassword)
+        self.verticalLayout_2 = QtWidgets.QVBoxLayout()
+        self.verticalLayout_2.setObjectName("verticalLayout_2")
+        self.formLayout.setLayout(6, QtWidgets.QFormLayout.FieldRole, self.verticalLayout_2)
         self.verticalLayout.addLayout(self.formLayout)
         self.buttonBox = QtWidgets.QDialogButtonBox(addUserDialog)
         self.buttonBox.setOrientation(QtCore.Qt.Horizontal)
@@ -56,18 +70,21 @@ def setupUi(self, addUserDialog):
         self.gridLayout.addLayout(self.verticalLayout, 0, 0, 1, 1)
 
         self.retranslateUi(addUserDialog)
-        self.buttonBox.accepted.connect(addUserDialog.accept)
-        self.buttonBox.rejected.connect(addUserDialog.reject)
+        self.buttonBox.accepted.connect(addUserDialog.accept) # type: ignore
+        self.buttonBox.rejected.connect(addUserDialog.reject) # type: ignore
         QtCore.QMetaObject.connectSlotsByName(addUserDialog)
 
     def retranslateUi(self, addUserDialog):
         _translate = QtCore.QCoreApplication.translate
         addUserDialog.setWindowTitle(_translate("addUserDialog", "Add user"))
+        self.usernameLabel.setText(_translate("addUserDialog", "Username:"))
         self.username.setPlaceholderText(_translate("addUserDialog", "John Doe"))
+        self.fullnamelabel.setText(_translate("addUserDialog", "Fullname:"))
+        self.fullname.setPlaceholderText(_translate("addUserDialog", "John Michael Doe"))
+        self.emailIDLabel.setText(_translate("addUserDialog", "Email:"))
         self.emailid.setPlaceholderText(_translate("addUserDialog", "[email protected]"))
         self.passwordLabel.setText(_translate("addUserDialog", "Password:"))
         self.password.setPlaceholderText(_translate("addUserDialog", "Your password"))
         self.confirmPasswordLabel.setText(_translate("addUserDialog", "Confirm Password:"))
         self.rePassword.setPlaceholderText(_translate("addUserDialog", "Confirm your password"))
-        self.emailIDLabel.setText(_translate("addUserDialog", "Email:"))
-        self.usernameLabel.setText(_translate("addUserDialog", "Username:"))
+