Mscolab refactor2 #2533
Merged
Mscolab refactor2 #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joernu76
force-pushed
the
mscolab_refactor2
branch
3 times, most recently
from
76bd423 to
8905a00
Compare
joernu76
force-pushed
the
mscolab_refactor2
branch
from
8905a00 to
c64067d
Compare
joernu76
force-pushed
the
mscolab_refactor2
branch
from
c64067d to
a3dfc2b
Compare
* Move (most) communication with server to ConnectionManager class to have consistent calls and error handling (e.g. timeout). * More consistently use json() method of response. * Removed single letter variables.
joernu76
force-pushed
the
mscolab_refactor2
branch
from
a3dfc2b to
0e45a73
Compare
ReimarBauer
reviewed
Sep 26, 2024
ReimarBauer
reviewed
Sep 26, 2024
| if r.status_code == 401: | ||
| raise requests.exceptions.ConnectionError | ||
| response = session.post(url, data=data, timeout=tuple(config_loader(dataset="MSCOLAB_timeout"))) | ||
| response.raise_for_status() |
There was a problem hiding this comment.
I am not sure what happens on e.g. 403 now.
The 401 in the past was used to get into the http_auth, which already is changed too.
There was a problem hiding this comment.
There was a problem hiding this comment.
I mean we only raised explicity on 401 raise requests.exceptions.ConnectionError
I have not found where it was used and got changed there now too
There was a problem hiding this comment.
The next envisioned change goes deeper in this direction, but I wanted to keep it "small".
ReimarBauer
reviewed
Sep 26, 2024
update copyright string
ReimarBauer
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Handle communication with server in a more consistent manner.
Does this PR introduce a breaking change?
No