Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2530 #2532

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix #2530 #2532

merged 1 commit into from
Sep 18, 2024

Conversation

joernu76
Copy link
Member

Purpose of PR?:

Fixes #2530

Does this PR introduce a breaking change?
no

If the changes in this PR are manually verified, list down the scenarios covered::
fixes double click issue
Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@joernu76 joernu76 marked this pull request as ready for review September 18, 2024 15:28
@joernu76
Copy link
Member Author

This seems to be the "correct" way to prevent a double trigger of buttons...

@ReimarBauer
Copy link
Member

site note, e.g. "Add User" does not crash but, we have the cancel button at the position where we had "Add" before.

There a double click does, "Add" and afterwards "Cancel". But there someone sees toggling the views.
I guess this is somehow by design of the mouse click events. It would be better if when there is only a single click expected all double or triple clicks should be taken as 1 click.

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@joernu76 joernu76 merged commit e33f8e3 into develop Sep 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

develop: doubleclick on mscolab login button gives a traceback
2 participants