Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ignoring some test files #2291

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

matrss
Copy link
Collaborator

@matrss matrss commented Mar 21, 2024

This PR is to keep an eye on if some other fix allows us to re-enable the test files that are skipped here:

--ignore=tests/_test_msui/test_sideview.py --ignore=tests/_test_msui/test_topview.py --ignore=tests/_test_msui/test_wms_control.py

@matrss matrss changed the base branch from develop to stable May 24, 2024 12:00
@matrss matrss force-pushed the stop-ignoring-some-test-files branch 2 times, most recently from 072560f to e075653 Compare May 24, 2024 12:07
@matrss matrss force-pushed the stop-ignoring-some-test-files branch 2 times, most recently from 7ecc043 to 9444060 Compare August 5, 2024 11:16
@matrss matrss marked this pull request as ready for review August 5, 2024 13:40
@matrss
Copy link
Collaborator Author

matrss commented Aug 5, 2024

It seems like something changed and this mostly works now.

@matrss matrss requested a review from ReimarBauer August 5, 2024 13:41
@ReimarBauer
Copy link
Member

running again to see if the result recures

@matrss
Copy link
Collaborator Author

matrss commented Aug 9, 2024

The one test run that failed I've also seen fail on current stable and develop (the macOS test runs in general seem to have occasional issues). The test that failed isn't even one of those that were re-enabled here.

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more tests :)

@matrss matrss merged commit 261b475 into Open-MSS:stable Aug 9, 2024
10 of 11 checks passed
@matrss matrss deleted the stop-ignoring-some-test-files branch August 9, 2024 19:11
joernu76 pushed a commit that referenced this pull request Aug 28, 2024
* removing pinned xmlschema (#2117)

* Stop ignoring some test files (#2291)

* Reconfigured tutorial videos for RTFD (#2458)

* changed to videos/

* use mss style on rtfd

* fix urls and text (#2460)

* Bump benc-uk/workflow-dispatch from 1.2.3 to 1.2.4 (#2450)

Bumps [benc-uk/workflow-dispatch](https://github.com/benc-uk/workflow-dispatch) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/benc-uk/workflow-dispatch/releases)
- [Commits](benc-uk/workflow-dispatch@v1.2.3...v1.2.4)

---
updated-dependencies:
- dependency-name: benc-uk/workflow-dispatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Limit video width to the containing block's width (#2463)

* pinning of libtiff is not needed but blocks a more recent libxml2 and others (#2469)

* fixed the model.Message description and tests now using op_id (#2470)

* bug fix for incomplete xml imports (#2468)

validate xml content

* prepare v9.2.0 (#2481)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Matthias Riße <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants