Fix : Updated seed module to use "mscolab_settings.ARCHIVE_THRESHOLD" #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se mscolab_settings.ARCHIVE_THRESHOLD
ReimarBauer
reviewed
Feb 23, 2024
| class mscolab_settings: | ||
| # In the unit months when Operations get archived because not used |
There was a problem hiding this comment.
good to add it here too. i just looked how it is configured in the https://github.com/Open-MSS/MSS/blob/develop/mslib/mscolab/conf.py#L44
I think we should keep it in days. I did not described it correctly in the issue.
Please change it to days so that it matches with the other occurencies where it is already used.
Another problem is, that I should have looked if this is because of refactoring in develop.
|
@workaryangupta please look on this in develop. My failure to think we can fix this in stable. |
Alright. I'll be closing this pull request in that case, will link a new one for the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?
Fixes #2227
Updated the seed module to always use
mscolab_settings.ARCHIVE_THRESHOLDinstead of hardcodeddateutil.relativedelta.relativedelta(months=**2**).