refactor wait until process signals instead pf sleep

[nilupulmanodya]

fixes #2074

[matrss]

Thanks for the PR! I think this is a bit more complicated than it needs to be though.

What I had in mind initially was to check stdout of the mscolab process for something that tells us that it is ready to accept connections. Unfortunately, it does not do that (the last thing it prints is "INFO: Launching MSColab Server", but that is from before it actually has set up its listening stuff so it does not tell us that it is ready to receive a connection).

Retrying is the next best thing, as you have implemented. curl includes an option for that though (curl --retry 5 --retry-connrefused, possibly varying --retry-delay as well). I think it would be better to just use that instead of implementing the retry logic again.

[nilupulmanodya]

Thanks for the PR! I think this is a bit more complicated than it needs to be though.

What I had in mind initially was to check stdout of the mscolab process for something that tells us that it is ready to accept connections. Unfortunately, it does not do that (the last thing it prints is "INFO: Launching MSColab Server", but that is from before it actually has set up its listening stuff so it does not tell us that it is ready to receive a connection).

Retrying is the next best thing, as you have implemented. curl includes an option for that though (curl --retry 5 --retry-connrefused, possibly varying --retry-delay as well). I think it would be better to just use that instead of implementing the retry logic again.

Thanks :)