-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature prepared for py311 #1923
Changes from all commits
20ea5cb
330d0e5
684adef
13f6b82
caacecb
1b2e0d4
1ff0618
401acce
231169a
98bb9e8
acc28eb
a15f8df
3f5753f
05ff577
4337d1f
1171779
45d076d
3c0ff3f
865259c
e562a18
2e0396c
f5d1edf
e34bf02
615e824
c471318
5cc560b
428c813
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -243,7 +243,6 @@ def fail_if_open_message_boxes_left(): | |
except RuntimeError: | ||
pass | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change seems wrong to me. Top-level functions should be separated by 2 newlines according to pep8. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ouch, but there are more |
||
@pytest.fixture(scope="session", autouse=True) | ||
def configure_testsetup(request): | ||
if Display is not None: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,16 +39,16 @@ requirements: | |
- chameleon | ||
- execnet | ||
- fastkml =0.11 | ||
- shapely <2.0.0 | ||
- shapely >=2.0.0 | ||
- pygeoif <1.0.0 | ||
- isodate | ||
- lxml | ||
- netcdf4 | ||
- hdf4 | ||
- pillow | ||
- pytz | ||
- pyqt >=5, <5.13 | ||
- qt >=5.10, <5.13 | ||
- pyqt >=5.15.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is needed to get recent python versions used. This also enables updating a lot dependent packages. |
||
- qt >=5.15.0 | ||
- requests >=2.31.0 | ||
- scipy | ||
- skyfield >=1.12 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,12 +48,16 @@ def test_keyring(): | |
|
||
|
||
def test_get_auth_from_url_and_name(): | ||
# set start condition to prevent definitions from a test earlier | ||
constants.AUTH_LOGIN_CACHE == {} | ||
# empty http_auth definition | ||
server_url = "http://example.com" | ||
http_auth = config_loader(dataset="MSS_auth") | ||
assert http_auth == {} | ||
data = auth.get_auth_from_url_and_name(server_url, http_auth, overwrite_login_cache=False) | ||
assert data == (None, None) | ||
# checking if the test setup changes this | ||
assert constants.AUTH_LOGIN_CACHE == {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this test on github sometimes seems like to have a bias from another test, related to TestMigration. It happens only here in serial tests. And it does not happen on each run. In that case at some point constants.AUTH_LOGIN_CACHE is not empty. |
||
# auth username and url defined | ||
auth_username = 'mss' | ||
create_msui_settings_file(f'{{"MSS_auth": {{"http://example.com": "{auth_username}"}}}}') | ||
|
@@ -63,6 +67,8 @@ def test_get_auth_from_url_and_name(): | |
data = auth.get_auth_from_url_and_name(server_url, http_auth, overwrite_login_cache=False) | ||
# no password yet | ||
assert data == (auth_username, None) | ||
# checking if the test setup changes this | ||
assert constants.AUTH_LOGIN_CACHE == {} | ||
# store a password | ||
auth.save_password_to_keyring(server_url, auth_username, "password") | ||
# return the test password | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solves the situation when a worker errors. without all tests of that worker in the queue would be skipped