Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use sleep as a synchronization primitive #2074

Closed
matrss opened this issue Nov 7, 2023 · 1 comment · Fixed by #2099
Closed

Do not use sleep as a synchronization primitive #2074

matrss opened this issue Nov 7, 2023 · 1 comment · Fixed by #2099
Assignees
@nilupulmanodya
Labels
SAML2 feature of 9.0 improvements

Comments

@matrss
Copy link
Collaborator

matrss commented Nov 7, 2023

MSS/mslib/mscolab/mscolab.py

Line 278 in f6b3ad1

time.sleep(10)

Not really optimal to use sleep as a synchronization primitive here (ideally it should wait until process signals that it is ready in some way, e.g. when process' stdout contains something that indicates that the server is up and running). This is not a very critical code path though, so not too much of a concern.

Originally posted by @matrss in #2069 (comment)
@matrss matrss added the SAML2 feature of 9.0 improvements label Nov 7, 2023
@nilupulmanodya
Copy link
Collaborator

@matrss I want to work on this, please assign me

@nilupulmanodya nilupulmanodya mentioned this issue Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilupulmanodya nilupulmanodya

Labels
SAML2 feature of 9.0 improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor wait until process signals instead pf sleep nilupulmanodya/MSS
2 participants
@matrss @nilupulmanodya